Repository navigation
zdxsv: shared guest addresses and network menu states in one header - #689
Merged
Merged
Conversation
…in one header Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
pcsx2/Zdxsv/GameAddresses.h: the guest addresses and network menu states that more than one file reads (GAME_GP,GAME_SCENE_BLOCK,GAME_NET_STATEand its sub state and step,GameNetConnectMenu,GameNetSettingList,GameNetDnas,GameNetLoginBrowser).FastBoot.cpp,FastLogin.cpp,NoDev9.cpp,AllyHp.cppdrop their own copies; literal states (0x27,0x21,3) use the names. No behavior change.Rationale behind Changes
The same addresses and state values were defined separately in four files.
Suggested Testing Steps
EMU=1 CLIENTS="1 3" GGPO=7101 GGPO_CLIENTS="1 3" m4z.pyPASS (emulog: no DEV9 device entry set, fast boot on, fast login via the local lobby) (platform info sent x2, GGPO battle, desync checks 0 mismatches), run with this PR and the lobby frame header PR merged locally.AllyHp.cpppaths have no rig run here.Did you use AI to help find, test, or implement this issue or feature?
Yes: written and tested by an AI agent (Claude Code).
🤖 Generated with Claude Code