8000 zdxsv: shared guest addresses and network menu states in one header by inada-s-ai[bot] · Pull Request #689 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

zdxsv: shared guest addresses and network menu states in one header - #689

Merged
inada-s merged 1 commit into
zdxsv-masterfrom
ai/game-addresses
Nov 19, 2026
Merged

inada-s merged 1 commit into
zdxsv-masterfrom
ai/game-addresses

Conversation

@inada-s-ai
@inada-s-ai inada-s-ai Bot commented Nov 18, 2026 •
Copy link
Copy Markdown

Description of Changes

  • New pcsx2/Zdxsv/GameAddresses.h: the guest addresses and network menu states that more than one file reads (GAME_GP, GAME_SCENE_BLOCK, GAME_NET_STATE and its sub state and step, GameNetConnectMenu, GameNetSettingList, GameNetDnas, GameNetLoginBrowser).
  • FastBoot.cpp, FastLogin.cpp, NoDev9.cpp, AllyHp.cpp drop their own copies; literal states (0x27, 0x21, 3) use the names. No behavior change.

Rationale behind Changes

The same addresses and state values were defined separately in four files.

Suggested Testing Steps

  • Run on windows-mini (private rig): Windows MSVC build; EMU=1 CLIENTS="1 3" GGPO=7101 GGPO_CLIENTS="1 3" m4z.py PASS (emulog: no DEV9 device entry set, fast boot on, fast login via the local lobby) (platform info sent x2, GGPO battle, desync checks 0 mismatches), run with this PR and the lobby frame header PR merged locally.
  • Not run: Linux, macOS, arm64 builds (CI); AllyHp.cpp paths have no rig run here.

Did you use AI to help find, test, or implement this issue or feature?

Yes: written and tested by an AI agent (Claude Code).

🤖 Generated with Claude Code

…in one header

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@inada-s
inada-s merged commit a543470 into zdxsv-master Nov 19, 2026
3 of 4 checks passed
@inada-s
inada-s deleted the ai/game-addresses branch November 19, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0