8000 zdxsv: drop the unused GGPO call mutex and the cold-page run count by inada-s-ai[bot] · Pull Request #687 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content
8000

zdxsv: drop the unused GGPO call mutex and the cold-page run count - #687

Merged
inada-s merged 1 commit into
zdxsv-masterfrom
ai/ggpo-cleanup
Nov 19, 2026
Merged

inada-s merged 1 commit into
zdxsv-masterfrom
ai/ggpo-cleanup

Conversation

@inada-s-ai
@inada-s-ai inada-s-ai Bot commented Nov 18, 2026
Copy link
Copy Markdown

Description of Changes

  • s_ggpo_mtx removed. Every GGPO call and GgpoStop run on the CPU thread, so the recursive mutex never had a second thread to guard against.
  • Delta states: a watched page written in a save interval always went hot (the threshold was 1), so the run count and s_last_write for cold pages were never read. Both removed; behaviour unchanged.

Rationale behind Changes

Less code that looks like it does something.

Suggested Testing Steps

  • Built locally (MSVC, Windows x64).
  • tests/zdxsv/rbk.py 2 1: PASS (private rig).
  • tests/zdxsv/deltatest.py: FAIL on this branch and the same FAIL on zdxsv-master 16880fe (every frame from 1501 on mismatches at IOP page 0x089000; private rig). Same counts on both, so not caused by this change. The master failure needs its own look.
  • Not run: macOS/Linux/arm64 builds.

Did you use AI to help find, test, or implement this issue or feature?

Yes. Written and tested by an AI agent (Claude Code).

🤖 Generated with Claude Code

@inada-s
inada-s merged commit < 81A3 code class="Link--primary text-bold">a370640 into zdxsv-master Nov 19, 2026
2 of 4 checks passed
@inada-s
inada-s deleted the ai/ggpo-cleanup branch November 19, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0