Repository navigation
8000
zdxsv: drop the unused GGPO call mutex and the cold-page run count - #687
Merged
Merged
Conversation
…-page run count of delta states
inada-s
merged commit <
81A3
code class="Link--primary text-bold">a370640
into
zdxsv-master
Nov 19, 2026
2 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
s_ggpo_mtxremoved. Every GGPO call andGgpoStoprun on the CPU thread, so the recursive mutex never had a second thread to guard against.s_last_writefor cold pages were never read. Both removed; behaviour unchanged.Rationale behind Changes
Less code that looks like it does something.
Suggested Testing Steps
tests/zdxsv/rbk.py 2 1: PASS (private rig).tests/zdxsv/deltatest.py: FAIL on this branch and the same FAIL onzdxsv-master16880fe (every frame from 1501 on mismatches at IOP page 0x089000; private rig). Same counts on both, so not caused by this change. The master failure needs its own look.Did you use AI to help find, test, or implement this issue or feature?
Yes. Written and tested by an AI agent (Claude Code).
🤖 Generated with Claude Code