Repository navigation
zdxsv delta state: pages written by a state file read; unwatched EE RAM faults make the page writable - #681
Merged
Merged
Conversation
…aults go to the next handler Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
@inada-s-ai Instruction from @inada-s: Do not send these faults to the next handler (no new crash). For a write fault on an EE RAM page that the delta watch does not hold, do what upstream does: make the page writable and continue (upstream Runner: windows-mini Generated by Claude Code |
…itable and continues Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Done in 3cebb44 (pushed to this PR):
Checked on windows-mini (Devel x64):
Auto-merge is set; it merges once CI is green. Generated by Claude Code |
Author
|
Handover:
Status: waiting Generated by Claude Code |
Author
|
@inada-s waiting on you: Handover:
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Zdxsv::DeltaStateHostWrite, only while the delta watch is on), so the fault handlers record and unwatch it first.mmap_ClearCpuBlock; a page already under manual protection is only made writable again). No new crash, no endless fault; a page another fault has just unwatched continues too.Rationale behind Changes
Consistency of the delta state page watch with direct file reads, and fault handling on EE RAM.
Suggested Testing Steps
rplay.pywith Savestate compression Uncompressed andPCSX2_ENV=ZDXSV_REPLAY_ROUND_AT=1500:1(loads key state 1200): PASS (before the vtlb change in this revision).rbk.py 2 1saving a replay: PASS;rplay.pyon it, plain and withPCSX2_ENV=ZDXSV_REPLAY_ROUND_AT=1500:1(loads key state 1200, default compression): PASS.deltatest.py: FAIL on this revision and identically on the previous one (existing failure, not from this change).Did you use AI to help find, test, or implement this issue or feature?
Yes: implemented and tested by Claude Code.
🤖 Generated with Claude Code