8000 CI: MSBuild Devel AVX2 and macOS arm64 builds by inada-s-ai[bot] · Pull Request #640 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

CI: MSBuild Devel AVX2 and macOS arm64 builds - #640

Merged
inada-s merged 2 commits into
zdxsv-masterfrom
ai/ci-msbuild-arm64
Nov 18, 2026
Merged

inada-s merged 2 commits into
zdxsv-masterfrom
ai/ci-msbuild-arm64

Conversation

@inada-s-ai
@inada-s-ai inada-s-ai Bot commented Nov 17, 2026 •
Copy link
Copy Markdown

Description of Changes

  • Windows: a second CI job, MSBuild Devel AVX2 (MSVC), compile only (package: false skips the zip, artifacts and symbols so it does not collide with the CMake job's artifact names).
  • macOS: new macos_build_arm64.yml, arm64 build + unit tests on every push and ready PR; no signing, no artifact, no secrets. The manual matrix keeps the x86_64 job only.
  • Docs: CI section of docs/zdxsv/tools.md, features.md line, tests/zdxsv/README.md row.
  • macOS fix: the crashpad handler copy used sentry_crashpad::handler, which sentry-native 0.17.6 does not export; it exports sentry_crashpad::crashpad_handler. Broke CMake generate on any macOS build with sentry.

Rationale behind Changes

CI built only CMake + clang-cl. Local builds and the rigs use MSBuild/MSVC, and the arm64 cores (pcsx2/arm64/, GS arm64 code) were never compiled in CI although arm64 players play against x86_64 players.

Suggested Testing Steps

  • Verified on windows-mini: the MSBuild job's command (msbuild PCSX2_qt.sln /m /p:Configuration="Devel AVX2" /p:Platform=x64) builds this branch, exit 0. All workflow files parse as YAML. Merges cleanly with PR 639.
  • Verified on a local macOS arm64 Mac: sentry-native 0.17.6 built with the deps script flags; its sentry_crashpad-targets.cmake defines only sentry_crashpad::crashpad_handler. Old line: CMake generate fails with the CI error; new line: configure, full build and make unittests (2/2) pass, crashpad_handler lands in PCSX2.app/Contents/MacOS.
  • Not run: the macOS x86_64 / universal deps build; the workflows on GitHub beyond the earlier arm64 run. The first arm64 run builds the universal deps without cache (about 55 min before CMake in that run).

Did you use AI to help find, test, or implement this issue or feature?

Yes: Claude Code wrote the change and ran the local build.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
inada-s commented Nov 18, 2026
Copy link
Copy Markdown
Owner

@inada-s-ai Instruction from @inada-s:

Fix this PR's branch until the macOS arm64 build passes.

The CI run of the macOS arm64 job (job 134564926005) failed at CMake generate:

CMake Error at pcsx2-qt/CMakeLists.txt:324 (add_custom_command):
  Error evaluating generator expression:
    $<TARGET_FILE:sentry_crashpad::handler>
  No target "sentry_crashpad::handler"

Runner: macos-mini


Generated by Claude Code

…:crashpad_handler

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@inada-s-ai
inada-s-ai Bot commented Nov 18, 2026
Copy link
Copy Markdown
Author

Fixed in b11f3ba on ai/ci-msbuild-arm64.

  • Cause: sentry-native 0.17.6 exports the handler executable as sentry_crashpad::crashpad_handler; sentry_crashpad::handler (the handler static lib) is not installed in a shared-lib build. pcsx2-qt/CMakeLists.txt now copies $<TARGET_FILE:sentry_crashpad::crashpad_handler>. Same line is on zdxsv-master, so every macOS build with sentry failed there too.
  • Verified on macos-mini (arm64): sentry-native 0.17.6 (same zip hash, the deps script's cmake flags) installed; sentry_crashpad-targets.cmake defines only sentry_crashpad::crashpad_handler.
    • Control, old line: CMake generate fails with the same error as the CI job.
    • New line: configure, full make, make unittests (2/2) pass; crashpad_handler is copied to PCSX2.app/Contents/MacOS/.
  • Not verified: the GitHub run itself (pushed, not waited for), the x86_64 macOS build.
  • The install_name_tool: no LC_RPATH lines in the deps step are non-fatal (the step continued to CMake).
  • @inada-s: merge CI: MSBuild Devel AVX2 and macOS arm64 builds #640 once the arm64 job is green.

Status: waiting

@inada-s
inada-s merged commit fd93171 into zdxsv-master Nov 18, 2026
4 checks passed
@inada-s
inada-s deleted the ai/ci-msbuild-arm64 branch November 18, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0