Repository navigation
CI: MSBuild Devel AVX2 and macOS arm64 builds - #640
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
@inada-s-ai Instruction from @inada-s: Fix this PR's branch until the macOS arm64 build passes. The CI run of the macOS arm64 job (job 134564926005) failed at CMake generate: Runner: macos-mini Generated by Claude Code |
…:crashpad_handler Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Fixed in b11f3ba on
Status: waiting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Devel AVX2(MSVC), compile only (package: falseskips the zip, artifacts and symbols so it does not collide with the CMake job's artifact names).macos_build_arm64.yml, arm64 build + unit tests on every push and ready PR; no signing, no artifact, no secrets. The manual matrix keeps the x86_64 job only.docs/zdxsv/tools.md,features.mdline,tests/zdxsv/README.mdrow.sentry_crashpad::handler, which sentry-native 0.17.6 does not export; it exportssentry_crashpad::crashpad_handler. Broke CMake generate on any macOS build with sentry.Rationale behind Changes
CI built only CMake + clang-cl. Local builds and the rigs use MSBuild/MSVC, and the arm64 cores (
pcsx2/arm64/, GS arm64 code) were never compiled in CI although arm64 players play against x86_64 players.Suggested Testing Steps
msbuild PCSX2_qt.sln /m /p:Configuration="Devel AVX2" /p:Platform=x64) builds this branch, exit 0. All workflow files parse as YAML. Merges cleanly with PR 639.sentry_crashpad-targets.cmakedefines onlysentry_crashpad::crashpad_handler. Old line: CMake generate fails with the CI error; new line: configure, full build andmake unittests(2/2) pass,crashpad_handlerlands inPCSX2.app/Contents/MacOS.Did you use AI to help find, test, or implement this issue or feature?
Yes: Claude Code wrote the change and ran the local build.
🤖 Generated with Claude Code