8000 Zdxsv: round states at the MS select before each briefing, rooms without a rematch screen included by inada-s · Pull Request #617 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

Zdxsv: round states at the MS select before each briefing, rooms without a rematch screen included - #617

Merged
inada-s merged 1 commit into
zdxsv-masterfrom
ai/select-start-fix
Nov 16, 2026
Merged

inada-s merged 1 commit into
zdxsv-masterfrom
ai/select-start-fix

Conversation

@inada-s
@inada-s inada-s commented Nov 16, 2026
Copy link
Copy Markdown
Owner

Description of Changes

  • Playback picks a round's MS-select load end as the load end just before the round's briefing (the span start). It used to take the first load end after the round before.
  • This replaces the PR 611 rule that sent such rounds to a seek, which treated them as rounds "without an MS select".
  • docs/zdxsv/replay.md updated.

Rationale behind Changes

A room that plays a set number of games shows no rematch screen. After a round its loads are MS select, then briefing. A room with a rematch screen loads rematch, MS select, briefing. So the first load end after a round is:

  • the MS select in a rematch-screen room only because the rematch load comes first, i.e. by luck;
  • the briefing in a set-number room. The round state taken there carried the round before, and jumps from it differed. PR 611 then sent those rounds to a seek.

The load end before the briefing is the MS select in both kinds of room.

Suggested Testing Steps

Private rig, Devel, Windows, production replays:

  • ZDXSV_REPLAY_ROUND_TAKE=1 ZDXSV_REPLAY_KEY=1000000, with ZDXSV_REPLAY_ROUND_AT jumps into every round.
  • 7 set-number 4-player rooms: each round now jumps from a round state (4 jumps), 0 differ. Before: rounds reached by a seek.
  • 5 rematch-screen replays (2, 3 and 4 players, up to 10 rounds): jumps as before, 0 differ after the jumps. One file differs before any jump, in plain playback, as before.

Not run: the live spectator, which carries no load frames or round states, so this path does not apply to it. Linux/macOS builds (CI).

Did you use AI to help find, test, or implement this issue or feature?

Yes: an AI agent traced the load order (tick state and MS-select work watches), wrote the change and ran the tests.

🤖 Generated with Claude Code

https://claude.ai/code/session_016yPS7ydVHAvg7ryR85YQ1C

…'s briefing, rooms without a rematch screen included

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016yPS7ydVHAvg7ryR85YQ1C
@inada-s
inada-s merged commit 51fcbe1 into zdxsv-master Nov 16, 2026
1 check passed
@inada-s
inada-s deleted the ai/select-start-fix branch November 16, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0