8000 Zdxsv: time the rerun VU1 and SPU2 split only with ZDXSV_RERUN_SPLIT by inada-s-ai[bot] · Pull Request #616 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

Zdxsv: time the rerun VU1 and SPU2 split only with ZDXSV_RERUN_SPLIT - #616

Merged
inada-s-ai[bot] merged 1 commit into
zdxsv-masterfrom
ai/rerun-split-timer
Nov 16, 2026
Merged

inada-s-ai[bot] merged 1 commit into
zdxsv-masterfrom
ai/rerun-split-timer

Conversation

@inada-s-ai
@inada-s-ai inada-s-ai Bot commented Nov 16, 2026 •
Copy link
Copy Markdown

Description of Changes

The VU1 and SPU2 timers of the battle report's rerun frame split line now run only with the new diagnostic env ZDXSV_RERUN_SPLIT=1 (row in docs/zdxsv/options.md). tests/zdxsv/benchab.py sets it, so its spu2 ms / vu1 ms parts still report.

Rationale behind Changes

Without the switch, every SPU2 tick of a rollback rerun read the performance counter twice only to fill that stats line. Unused diagnostics must not cost performance; rerun frames are a bit faster without it.

Suggested Testing Steps

  • Done, windows-mini (private rig): built locally; a GGPO battle via rbk.py 2 1 without the env reports spu2 ms 0.000, with ZDXSV_RERUN_SPLIT=1 reports ~0.39. A replay-seek speed A/B against zdxsv-master (4 pairs) shows faster rerun frames in every pair with the same replay outcome.
  • benchab.py "" "" 1 ran (private rig): spu2_ms reports ~0.39 on both sides.
  • Not run: CI platforms other than Windows.

Did you use AI to help find, test, or implement this issue or feature?

Yes: Claude Code found the hot spot in a profile, wrote the change and ran the tests above.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@inada-s-ai
inada-s-ai Bot enabled auto-merge November 16, 2026 23:18
@inada-s-ai
inada-s-ai Bot merged commit dcc3e72 into zdxsv-master Nov 16, 2026
1 check passed
@inada-s-ai
inada-s-ai Bot deleted the ai/rerun-split-timer branch November 16, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants

0