Repository navigation
Zdxsv: time the rerun VU1 and SPU2 split only with ZDXSV_RERUN_SPLIT - #616
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The VU1 and SPU2 timers of the battle report's
rerun frame splitline now run only with the new diagnostic envZDXSV_RERUN_SPLIT=1(row indocs/zdxsv/options.md).tests/zdxsv/benchab.pysets it, so itsspu2 ms/vu1 msparts still report.Rationale behind Changes
Without the switch, every SPU2 tick of a rollback rerun read the performance counter twice only to fill that stats line. Unused diagnostics must not cost performance; rerun frames are a bit faster without it.
Suggested Testing Steps
rbk.py 2 1without the env reportsspu2 ms 0.000, withZDXSV_RERUN_SPLIT=1reports ~0.39. A replay-seek speed A/B againstzdxsv-master(4 pairs) shows faster rerun frames in every pair with the same replay outcome.benchab.py "" "" 1ran (private rig):spu2_msreports ~0.39 on both sides.Did you use AI to help find, test, or implement this issue or feature?
Yes: Claude Code found the hot spot in a profile, wrote the change and ran the tests above.
🤖 Generated with Claude Code