Repository navigation
SPU2: force-inline the lazy voice guards in the mixer - #613
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
SpuLazySkipandSpuLazyWakeinpcsx2/Zdxsv/SpuHooks.hare nowstatic __fiinstead ofinline.Rationale behind Changes
MSVC did not inline
SpuLazySkip, which the SPU2 mixer calls for every stopped voice on every tick. It showed up as its own function in the profile. Force-inlining it makes replay seeking (rerun) a little faster. No behavior change.Suggested Testing Steps
zdxsv-master. Rerun was faster in 3 of the 4 pairs, and the game RNG fingerprint was the same in every run.Did you use AI to help find, test, or implement this issue or feature?
Yes. An AI agent profiled the mixer, made the change, and ran the build and the A/B.
🤖 Generated with Claude Code