8000 SPU2: force-inline the lazy voice guards in the mixer by inada-s-ai[bot] · Pull Request #613 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

SPU2: force-inline the lazy voice guards in the mixer - #613

Merged
inada-s-ai[bot] merged 1 commit into
zdxsv-masterfrom
ai/spu2-lazy-inline
Nov 16, 2026
Merged

inada-s-ai[bot] merged 1 commit into
zdxsv-masterfrom
ai/spu2-lazy-inline

Conversation

@inada-s-ai
@inada-s-ai inada-s-ai Bot commented Nov 16, 2026
Copy link
Copy Markdown

Description of Changes

SpuLazySkip and SpuLazyWake in pcsx2/Zdxsv/SpuHooks.h are now static __fi instead of inline.

Rationale behind Changes

MSVC did not inline SpuLazySkip, which the SPU2 mixer calls for every stopped voice on every tick. It showed up as its own function in the profile. Force-inlining it makes replay seeking (rerun) a little faster. No behavior change.

Suggested Testing Steps

  • Verified locally (Windows, private replay rig): MSVC build, and an A/B of replay seeking (4 pairs) against zdxsv-master. Rerun was faster in 3 of the 4 pairs, and the game RNG fingerprint was the same in every run.
  • Not run: CI, Linux/macOS builds.

Did you use AI to help find, test, or implement this issue or feature?

Yes. An AI agent profiled the mixer, made the change, and ran the build and the A/B.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@inada-s-ai
inada-s-ai Bot enabled auto-merge November 16, 2026 22:30
@inada-s-ai
inada-s-ai Bot merged commit b4d29de into zdxsv-master Nov 16, 2026
1 check passed
@inada-s-ai
inada-s-ai Bot deleted the ai/spu2-lazy-inline branch November 16, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants

0