Repository navigation
SPU2: step stopped voices without the output math - #610
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
SPU2
MixCoreVoices: a stopped voice runs a dedicated step (volume slide, decode position/NAX, block header, pitch, consume, voice 1/3 write-back) and skips the output math and the dry/wet accumulation of a silent sample.Rationale behind Changes
In GGPO battles most of the 48 voices are stopped but still stepped every sample. Same state changes as before (same calls in the same order); only computations whose result is zero are skipped. Part of speeding up rollback frames (#606).
Suggested Testing Steps
Did you use AI to help find, test, or implement this issue or feature?
Yes: Claude Code profiled the bench, wrote the change and ran the A/B.
🤖 Generated with Claude Code