8000 Zdxsv: no replay save or upload for a session with no confirmed frame by inada-s · Pull Request #609 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

Zdxsv: no replay save or upload for a session with no confirmed frame - #609

Merged
inada-s merged 1 commit into
zdxsv-masterfrom
ai/replay-skip-empty
Nov 16, 2026
Merged

inada-s merged 1 commit into
zdxsv-masterfrom
ai/replay-skip-empty

Conversation

@inada-s
@inada-s inada-s commented Nov 16, 2026
Copy link
Copy Markdown
Owner

Description of Changes

ReplayWrite returns before saving or uploading when GGPO confirmed no frame (logs replay: no confirmed frame (<reason>), not saved or uploaded). The live stream is still closed. docs/zdxsv/replay.md states it.

Rationale behind Changes

A session that fails before frame 0 posted a 0-frame .pb to /lbs/replay_upload. The lobby keeps the first upload, so such a file can take the battle's slot (409 for the peers' files), and the replay list shows a battle that does not play (replay: not started). A production 4-player battle had one (players 4, position 3, frames 0, end failed).

Suggested Testing Steps

Built locally (Devel). Not run: a session failing before frame 0 (no rig test added). Already uploaded empty files on the server are not handled here.

Did you use AI to help find, test, or implement this issue or feature?

Yes: found by playing production replays with an AI agent, which also wrote the change.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8548
@inada-s
inada-s merged commit f1dd8bf into zdxsv-master Nov 16, 2026
1 check passed
@inada-s
inada-s deleted the ai/replay-skip-empty branch November 16, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0