Repository navigation
Zdxsv: no replay save or upload for a session with no confirmed frame - #609
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8548
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
ReplayWritereturns before saving or uploading when GGPO confirmed no frame (logsreplay: no confirmed frame (<reason>), not saved or uploaded). The live stream is still closed.docs/zdxsv/replay.mdstates it.Rationale behind Changes
A session that fails before frame 0 posted a 0-frame
.pbto/lbs/replay_upload. The lobby keeps the first upload, so such a file can take the battle's slot (409 for the peers' files), and the replay list shows a battle that does not play (replay: not started). A production 4-player battle had one (players 4, position 3, frames 0, endfailed).Suggested Testing Steps
Built locally (Devel). Not run: a session failing before frame 0 (no rig test added). Already uploaded empty files on the server are not handled here.
Did you use AI to help find, test, or implement this issue or feature?
Yes: found by playing production replays with an AI agent, which also wrote the change.
🤖 Generated with Claude Code