Repository navigation
Zdxsv: replay benchmark of the rollback cycle - #607
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
ZDXSV_REPLAY_BENCH=at:depth:reps(diagnostic): during replay playback, from frameatevery frame is saved as a delta state; after eachdepthplayed frames the first of them is loaded and the frames rerun the way a GGPO rollback reruns them (same draw / VU1 skip flags, rerun keep,GgpoRunFrame),repstimes. At the end it logs wall ms of a played frame, a rerun frame, a save and a load (mean, median, p10, p90, max). New filepcsx2/Zdxsv/ReplayBench.cpp; three one-line calls in the replay code; off = no change.Rationale behind Changes
A repeatable benchmark of the GGPO frame costs on real battle frames (a replay), as the base for tuning game speed in GGPO battles (#606).
Suggested Testing Steps
Verified on windows-mini (private rig): built (MSBuild Release),
PCSX2_ENV=ZDXSV_REPLAY_BENCH=6000:8:200 MAXS=90 rplay.pyon a 4-player replay:replay bench done, 200 of 200 rollbacks, all four parts logged; itsstate hash differslines equal those of the same replay on the build before this one without the knob (the reruns reproduce the played frames). Not run: Linux/macOS builds (CI), windowed renderer timing.Did you use AI to help find, test, or implement this issue or feature?
Yes: written and tested by Claude Code.
🤖 Generated with Claude Code