Repository navigation
Zdxsv: rplay.py fails at once on an EE exception - #605
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
tests/zdxsv/rplay.pynow also fails right away when the emulog showsR5900 Exception:(for exampleJump to unaligned address). Before, it ran on to MAXS. The docstring states this.Rationale behind Changes
After an EE exception the VM pauses but pcsx2 keeps running. The replay never ends, so each crashed rig run used up its whole MAXS (up to 400 s) before it failed.
Suggested Testing Steps
Verified on windows-mini (private rig, commit f7d2392). Input: a replay with a debug-build EE memory patch that crashes at 111 s.
FAIL replay error at 111 s, 115 s wall.roundjump.pyemulogs (pass and control) have noR5900 Exceptionline, so passing runs are not affected.Did you use AI to help find, test, or implement this issue or feature?
Yes. An AI agent wrote and tested the change.
🤖 Generated with Claude Code