Repository navigation
Zdxsv: replay round jump after a point-of-view switch runs to the first load end first - #603
Merged
Merged
Conversation
…then jumps Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
A seek that would round-jump but has no key at the first load end for the shown position runs to the first load end first, saves that key, and then jumps. This happens on a point-of-view switch after a jump, because the new position's keys start empty.
Rationale behind Changes
Before this change, a point-of-view switch after a round jump ran every frame from key 0 to the target (about 17000 frames, 72 s on the test file). Now it runs 218 frames, jumps, and runs on from the round state (about 10 s).
Suggested Testing Steps
tests/zdxsv/roundjump.pywithPCSX2_ENV=ZDXSV_REPLAY_POV_AT=17000:2on a 3-round 4p recording with round states: PASS (0 hashes and 0 rngs differ). The log shows a secondround jumpafter the switch.ROUND=7: PASS. ControlZDXSV_REPLAY_ROUND_BAD=1with the switch: FAIL as it should; the fallback seek then matches the file.Did you use AI to help find, test, or implement this issue or feature?
Yes. Claude Code wrote the change and ran the rig tests above.
🤖 Generated with Claude Code