8000 Zdxsv: replay round jump after a point-of-view switch runs to the first load end first by inada-s-ai[bot] · Pull Request #603 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

Zdxsv: replay round jump after a point-of-view switch runs to the first load end first - #603

Merged
inada-s-ai[bot] merged 1 commit into
zdxsv-masterfrom
ai/replay-round-jump-pov
Nov 16, 2026
Merged

inada-s-ai[bot] merged 1 commit into
zdxsv-masterfrom
ai/replay-round-jump-pov

Conversation

@inada-s-ai
@inada-s-ai inada-s-ai Bot commented Nov 16, 2026
Copy link
Copy Markdown

Description of Changes

A seek that would round-jump but has no key at the first load end for the shown position runs to the first load end first, saves that key, and then jumps. This happens on a point-of-view switch after a jump, because the new position's keys start empty.

Rationale behind Changes

Before this change, a point-of-view switch after a round jump ran every frame from key 0 to the target (about 17000 frames, 72 s on the test file). Now it runs 218 frames, jumps, and runs on from the round state (about 10 s).

Suggested Testing Steps

  • tests/zdxsv/roundjump.py with PCSX2_ENV=ZDXSV_REPLAY_POV_AT=17000:2 on a 3-round 4p recording with round states: PASS (0 hashes and 0 rngs differ). The log shows a second round jump after the switch.
  • Plain ROUND=7: PASS. Control ZDXSV_REPLAY_ROUND_BAD=1 with the switch: FAIL as it should; the fallback seek then matches the file.
  • Run on a private rig (Windows, MSVC build, commit ce41b84). Not run on Linux or macOS.

Did you use AI to help find, test, or implement this issue or feature?

Yes. Claude Code wrote the change and ran the rig tests above.

🤖 Generated with Claude Code

…then jumps

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@inada-s-ai
inada-s-ai Bot enabled auto-merge November 16, 2026 07:12
@inada-s-ai
inada-s-ai Bot merged commit 9614ffb into zdxsv-master Nov 16, 2026
1 check passed
@inada-s-ai
inada-s-ai Bot deleted the ai/replay-round-jump-pov branch November 16, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants

0