Repository navigation
Zdxsv: replay round jump from a recorded round state - #602
Merged
Merged
Conversation
…rst load end's key Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…seeks again without round states Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…roundjump.py test and docs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on Git
5FA6
Hub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
BattleLogFile.round_states(field 61).ZDXSV_REPLAY_ROUND_TAKE=1(playback takes round states, for old files),ZDXSV_REPLAY_ROUND_BAD=1(control). New testtests/zdxsv/roundjump.py.Rationale behind Changes
A first jump to a later round ran every frame from the start (10-25 s). Now it starts from that round's state (about 150 ms) and runs only the frames after it.
Suggested Testing Steps
ROUND=7 roundjump.py(jump from frame 400 to the third round's MS selection): PASS, player work equals the four live traces, 0 differing hashes and RNGs.ROUND=3: PASS. ControlZDXSV_REPLAY_ROUND_BAD=1: FAIL (caught, the fallback seek then matches the file).ZDXSV_REPLAY_ROUND_TAKE=1: PASS; recording in 1v1 GGPO: a round state per load end.Did you use AI to help find, test, or implement this issue or feature?
Yes: written and tested by an AI agent (Claude Code).
🤖 Generated with Claude Code