8000 Replay seek: no black picture when stepping back onto a key frame by inada-s · Pull Request #587 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

Replay seek: no black picture when stepping back onto a key frame - #587

Merged
inada-s merged 1 commit into
zdxsv-masterfrom
ai/replay-seek-key-picture
Nov 14, 2026
Merged

inada-s merged 1 commit into
zdxsv-masterfrom
ai/replay-seek-key-picture

Conversation

@inada-s
@inada-s inada-s commented Nov 14, 2026
Copy link
Copy Markdown
Owner

Description of Changes

A replay seek loads the newest key at least two frames before the target; a key at the target is used only when there is no earlier one. replay.md says so.

Rationale behind Changes

A key load resets the GS. Stepping back onto a key frame (every 600 frames, for example 3000) loaded that key and ran no frame, so the paused picture was black.

Suggested Testing Steps

  • Private rig (Windows, D3D11, 3x): rplay.py WINDOW=1 with ZDXSV_REPLAY_KEY=60, 70 steps back across keys, with a local debug patch logging every window present: before, the key frame had no picture; after, every step shows a picture (the key frame runs 60 frames from the previous key).
  • Tested by the owner: frame 3000 is no longer black.
  • Not run: point of view switches onto a key frame, other OSes.

Did you use AI to help find, test, or implement this issue or feature?

Yes. Claude Code found the cause, wrote the change and ran the rig.

🤖 Generated with Claude Code

… target has a picture

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@inada-s
inada-s merged commit 3d03dcb into zdxsv-master Nov 14, 2026
1 check passed
@inada-s
inada-s deleted the ai/replay-seek-key-picture branch November 14, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0