Repository navigation
Replay seek: no black picture when stepping back onto a key frame - #587
Merged
Merged
Conversation
… target has a picture Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
A replay seek loads the newest key at least two frames before the target; a key at the target is used only when there is no earlier one. replay.md says so.
Rationale behind Changes
A key load resets the GS. Stepping back onto a key frame (every 600 frames, for example 3000) loaded that key and ran no frame, so the paused picture was black.
Suggested Testing Steps
rplay.pyWINDOW=1 withZDXSV_REPLAY_KEY=60, 70 steps back across keys, with a local debug patch logging every window present: before, the key frame had no picture; after, every step shows a picture (the key frame runs 60 frames from the previous key).Did you use AI to help find, test, or implement this issue or feature?
Yes. Claude Code found the cause, wrote the change and ran the rig.
🤖 Generated with Claude Code