8000 Replay step: no flash of the next frame when a step resumes from a pause by inada-s · Pull Request #586 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

Replay step: no flash of the next frame when a step resumes from a pause - #586

Merged
inada-s merged 1 commit into
zdxsv-masterfrom
ai/replay-step-pending-present
Nov 14, 2026
Merged

inada-s merged 1 commit into
zdxsv-masterfrom
ai/replay-step-pending-present

Conversation

@inada-s
@inada-s inada-s commented Nov 14, 2026
Copy link
Copy Markdown
Owner

Description of Changes

When a paused replay resumes for a step (or a seek from a pause), the present still queued from the paused frame is hidden.

Rationale behind Changes

Replay frames run from a game hook after the vsync, and their show/hide flags apply to the next vsync. A pause at a frame leaves that frame's present queued; on a step that vsync comes before the seek, so the picture one frame ahead flashed before the step's picture.

Suggested Testing Steps

  • Private rig (Windows, D3D11, 3x, the owner's GS settings): rplay.py WINDOW=1, pause then step back / forward, with a local debug patch logging a hash of every window present: before, the frame ahead was presented on each step; after, the queued present is hidden and the shown pictures go back / forward one frame each.
  • Tested by the owner with the pad D-pad: no flash.
  • Not run: other renderers, other OSes.

Did you use AI to help find, test, or implement this issue or feature?

Yes. Claude Code found the cause, wrote the change and ran the rig.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@inada-s
inada-s merged commit 5264a76 into zdxsv-master Nov 14, 2026
1 check passed
@inada-s
inada-s deleted the ai/replay-step-pending-present branch November 14, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0