Repository navigation
Replay step: no flash of the next frame when a step resumes from a pause - #586
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
When a paused replay resumes for a step (or a seek from a pause), the present still queued from the paused frame is hidden.
Rationale behind Changes
Replay frames run from a game hook after the vsync, and their show/hide flags apply to the next vsync. A pause at a frame leaves that frame's present queued; on a step that vsync comes before the seek, so the picture one frame ahead flashed before the step's picture.
Suggested Testing Steps
rplay.pyWINDOW=1, pause then step back / forward, with a local debug patch logging a hash of every window present: before, the frame ahead was presented on each step; after, the queued present is hidden and the shown pictures go back / forward one frame each.Did you use AI to help find, test, or implement this issue or feature?
Yes. Claude Code found the cause, wrote the change and ran the rig.
🤖 Generated with Claude Code