8000 Pad: skip unnamed binding slots in macro lookups (upstream bug: NeGcon/Jogcon crash) by inada-s-ai[bot] · Pull Request #583 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

Pad: skip unnamed binding slots in macro lookups (upstream bug: NeGcon/Jogcon crash) - #583

Merged
inada-s merged 1 commit into
zdxsv-masterfrom
ai/pad-null-bind-name
Nov 14, 2026
Merged

inada-s merged 1 commit into
zdxsv-masterfrom
ai/pad-null-bind-name

Conversation

@inada-s-ai
@inada-s-ai inada-s-ai Bot commented Nov 14, 2026
Copy link
Copy Markdown

Description of Changes

Fixes upstream code. Pad::ControllerInfo::GetBindIndex and the macro editor (ControllerMacroEditWidget) skip binding slots that have no name. Adds the rig test tests/zdxsv/padmacro.py.

Rationale behind Changes

The NeGcon and Jogcon binding tables have unnamed {} placeholder slots. A macro button that is not found before such a slot (for example Start on NeGcon, often left over after switching from DualShock 2) gets compared with a null name, so strlen(nullptr) crashes. This happens when the pad config loads at startup and when the Controllers dialog builds the macro page. Sentry has a crash report from zdxsv-1.0.1 with this stack (ControllerMacroEditWidget constructor → strlen). Upstream PCSX2 master still has the bug.

Suggested Testing Steps

  • RUN=<dir> python tests/zdxsv/padmacro.py (no game, no network). Result on windows-mini (private rig) at 4d15d5a: PASS. The control, release zdxsv-1.0.0: FAIL, a startup crash (0xC0000005 in ucrtbase).
  • By hand on windows-mini: opened Settings > Controllers with that config. The fixed build stayed up. A build without the fix crashes at startup before the dialog can open.
  • Not run: macOS/Linux, and the macro actually pressing Start in a game.

Did you use AI to help find, test, or implement this issue or feature?

Yes. Claude Code found the cause from the crash report, wrote the fix and the test, and ran them.

🤖 Generated with Claude Code

…, strlen on null name)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@inada-s
inada-s merged commit 416a844 into zdxsv-master Nov 14, 2026
1 check passed
@inada-s
inada-s deleted the ai/pad-null-bind-name branch November 14, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0