Repository navigation
Replay window: play in a child pcsx2 process - #581
Merged
Merged
Conversation
…, the game keeps running Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 13, 2026
Closed
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…y child in a battle and a failed start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Play in the replay window (local, remote, favorites, live) starts a child pcsx2 process (
-nogui -zdxsvreplay <pov>:<parent pid>:<source>) instead of shutting down the running game. The child reads the parent's settings; its saves, cache, logs and save states go to<data dir>/replay-child/. In the child, memory cards, DEV9, fast boot/login, replay save/upload, crash reports, achievements, Discord and the update check are off, and no play time is added. It exits at the replay's end, when the replay does not start, when its window closes, or within 1 s of the parent exiting. Only one child runs at a time; Play is refused during a net battle.ZdxsvReplayReturnis removed: the game is never stopped, so there is nothing to return to.Rationale behind Changes
The player can stay in the lobby while watching a replay or a live battle. Issue: #579
Suggested Testing Steps
CHILD=1 rplay.pyon a 2p replay → PASS: replay state hashes 0 differ, the child exits, the instance's files are unchanged. Control: the build without the play time guard FAILs oninis/playtime.dat.lobbychild.py→ PASS: a parent logged in to the local lobby keeps its connection and files while a child plays a 2p replay (0 differ, no TCP/UDP) and exits;KILL_PARENT_S=20→ the child exits after the parent is killed. ControlINPROC=1FAILs oninis/PCSX2.ini,inis/playtime.dat.m4z.pysolo GGPO battle withSIDE_CHILD→ 0 mismatches, 0 rollback frames (same as without a child), child 0 differ.m4z.py1v1 GGPO battle withSIDE_CHILDon one client, 3 runs → 0 mismatches on both peers, rollback frames 0/0, 1/9, 0/0 (no child: 0/0 over 2 runs), child 0 differ. The rig launches the child itself; the Play button path (which no longer sets a priority) was only built, not run.m4z.py1v1 GGPO battle withSIDE_CHILDplaying the battle's live stream → 0 mismatches, rollback frames 0/0, child 9560 state hashes 0 differ, exit 0.CHILD=1 rplay.pyandlobbychild.pyagain after the return-state cleanup → PASS, 0 differ. Same on a local merge with Replay step: no audio burst, fast step back, step hotkeys #580 (git merges cleanly, MSBUILD_RC=0, both PASS).Did you use AI to help find, test, or implement this issue or feature?
Yes: Claude Code wrote the change and ran the rig check.
🤖 Generated with Claude Code