Repository navigation
Zdxsv: keep the fast login result for a new user's lobby connect after the battle - #553
Merged
Merged
Conversation
…a new user, so the lobby connect after the first battle works Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fast login writes its login result back into the game's result area when the game has cleared it, outside the user selection and login browser phases.
Rationale behind Changes
After the first battle of a newly made user, the game reconnected to
0.0.0.0:0, showed that it could not connect to the server, and went black. The result area it reads the lobby address from had been cleared. What clears it is not identified; the fix does not depend on it. Existing users are unaffected: their result area does not change.Suggested Testing Steps
Tested (private rig, headless): 1v1 GGPO lobby battle, one existing and one new user. Without the fix the new user's connect after the battle is refused; with it both return to the lobby and both results are recorded.
Not tested: 4 players, TLS on. Not changed: the black screen once the game is in its login browser reconnect path after another failure.
Did you use AI to help find, test, or implement this issue or feature?
Yes. Claude Code reproduced the failure on the private rig, wrote the fix and this PR.
🤖 Generated with Claude Code