Repository navigation
P2PMatchingReport: display misses by rollback depth and rollback_slack; remove the 1.10.2 room fields - #440
Merged
Merged
Conversation
…ith Present wait elasticity; 1.10.2 room fields deprecated Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nted display misses by depth) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… display misses) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…no longer logs them Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
inada-s
marked this pull request as ready for review
October 24, 2026 13:02
…elds were removed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ja3eWX1HNkp6VE7YpJy2Hv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proto and LBS log part of the frame-timing fix for inada-s/flycast#573. Client: inada-s/flycast#577.
Merge order: this PR first, then deploy LBS, then inada-s/flycast#577. Without the LBS deploy, LBS drops the new client fields as unknown and does not log them.
FrameTiming.rollback_room,over_periodandover_period_depth_histare deleted; numbers 3-5 and the names are reserved, like the budget fields 37-39 inP2PMatchingReport.P2PMatchingReport.present_depth_hist,late_present_depth_hist,dropped_depth_hist(42-44): Present / late / dropped counts by the depth of the rollback before them.display_stats_presents,display_miss_depth_hist,display_composed_presents(45-47): display misses by depth from DXGI frame statistics (DX11 flip model).FrameTiming.present_wait_elasticity(10) androllback_slack(11).Verified (windows-mini):
go build ./...,go vet,go test ./...pass. The LBS test sends 3-5 as raw 1.10.2 wire bytes and checks they are not logged; control: with the previous proto and logging code it fails. Client-side checks of what the fields count: inada-s/flycast#577.Not verified: golangci-lint (not installed there); no run against a deployed LBS.
🤖 Generated with Claude Code