8000 P2PMatchingReport: display misses by rollback depth and rollback_slack; remove the 1.10.2 room fields by inada-s-ai[bot] · Pull Request #440 · inada-s/gdxsv · GitHub
[go: up one dir, main page]

Skip to content

P2PMatchingReport: display misses by rollback depth and rollback_slack; remove the 1.10.2 room fields - #440

Merged
inada-s merged 6 commits into
masterfrom
ai/frame-timing-v2
Oct 24, 2026
Merged

inada-s merged 6 commits into
masterfrom
ai/frame-timing-v2

Conversation

@inada-s-ai
@inada-s-ai inada-s-ai Bot commented Oct 24, 2026 •
Copy link
Copy Markdown
Contributor

Proto and LBS log part of the frame-timing fix for inada-s/flycast#573. Client: inada-s/flycast#577.

Merge order: this PR first, then deploy LBS, then inada-s/flycast#577. Without the LBS deploy, LBS drops the new client fields as unknown and does not log them.

  • 1.10.2's FrameTiming.rollback_room, over_period and over_period_depth_hist are deleted; numbers 3-5 and the names are reserved, like the budget fields 37-39 in P2PMatchingReport.
  • New fields:
    • P2PMatchingReport.present_depth_hist, late_present_depth_hist, dropped_depth_hist (42-44): Present / late / dropped counts by the depth of the rollback before them.
    • display_stats_presents, display_miss_depth_hist, display_composed_presents (45-47): display misses by depth from DXGI frame statistics (DX11 flip model).
    • FrameTiming.present_wait_elasticity (10) and rollback_slack (11).
  • LBS logs the new fields. 1.10.2 clients still send 3-5; they are now unknown fields and are not logged.

Verified (windows-mini): go build ./..., go vet, go test ./... pass. The LBS test sends 3-5 as raw 1.10.2 wire bytes and checks they are not logged; control: with the previous proto and logging code it fails. Client-side checks of what the fields count: inada-s/flycast#577.

Not verified: golangci-lint (not installed there); no run against a deployed LBS.

🤖 Generated with Claude Code

…ith Present wait elasticity; 1.10.2 room fields deprecated

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
inada-s-ai Bot and others added 4 commits October 24, 2026 21:08
…nted display misses by depth)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… display misses)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…no longer logs them

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@inada-s-ai inada-s-ai Bot changed the title P2PMatchingReport: display misses by rollback depth and rollback_slack; deprecate the 1.10.2 room fields P2PMatchingReport: display misses by rollback depth and rollback_slack; remove the 1.10.2 room fields Oct 24, 2026
@inada-s
inada-s marked this pull request as ready for review October 24, 2026 13:02
…elds were removed

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ja3eWX1HNkp6VE7YpJy2Hv
@inada-s
inada-s merged commit 8f6870e into master Oct 24, 2026
2 checks passed
@inada-s
inada-s deleted the ai/frame-timing-v2 branch October 24, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0