8000 Fix live spectating startup with large game patches by vkedwardli · Pull Request #427 · inada-s/gdxsv · GitHub
[go: up one dir, main page]

Skip to content

Fix live spectating startup with large game patches - #427

Merged
inada-s merged 1 commit into
inada-s:masterfrom
vkedwardli:fix/live-spectator-patch-chunking
Sep 26, 2026
Merged

inada-s merged 1 commit into
inada-s:masterfrom
vkedwardli:fix/live-spectator-patch-chunking

Conversation

@vkedwardli
Copy link
Copy Markdown
Contributor

LBS chunks the patch list but previously never split an individual patch. A large ac patch therefore exceeded Flycast’s 8,192-byte receive buffer, causing repeated packet rejection and a bootstrap timeout.

Compatible with existing Flycast-gdxsv clients

Changes

  • Split large patches into smaller GamePatch entries, preserving metadata and code order.
  • Reuse existing patch counts and ACKs—no protocol change or Flycast update required.
  • Include protobuf field overhead in the patch-chunk budget.
  • Leave normal battle patch delivery unchanged.

Verification

  • All Go tests pass.
  • Spectator tests pass with race detection.
  • Regression test covers oversized patches, retries, ordering, and preservation of the original patch list.

- Split oversized code lists into ordered GamePatch entries.
- Reuse existing patch counts and ACKs for older client compatibility.
- Preserve normal battle patch delivery.
- Test packet sizes, retries, and complete code delivery.
@codecov
codecov Bot commented Sep 26, 2026
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.83%. Comparing base (46f6469) to head (b9d381e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
+ Coverage   69.69%   69.83%   +0.13%     
==========================================
  Files          25       25              
  Lines        5462     5483      +21     
==========================================
+ Hits         3807     3829      +22     
+ Misses       1364     1363       -1     
  Partials      291      291              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@inada-s
inada-s merged commit d6ddd0b into inada-s:master Sep 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0