[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user @grpc/grp-js instead of grpc #234

Closed
wants to merge 4 commits into from

Conversation

117sparta
Copy link

Changes

Verification

@zetaron zetaron mentioned this pull request Jun 4, 2020
@badsyntax
Copy link
Contributor

would love to see this merged so i can stop changing (hacking) the import paths as a post process.

i initially added the grpc_js option (see grpc/grpc-node#1380) and had planned to send a PR to this repo but never got around to it.

@117sparta
Copy link
Author
117sparta commented Jun 16, 2020

would love to see this merged so i can stop changing (hacking) the import paths as a post process.

i initially added the grpc_js option (see grpc/grpc-node#1380) and had planned to send a PR to this repo but never got around to it.

You can search jerry-ts-protoc-gen in npm. I publish this pr as an npm package. Maybe you can try using it. link

@badsyntax
Copy link
Contributor

Thanks. It would be best if this package added support for it. I found some code that I made a while ago and have published it with #236

That PR won't change the default behaviour of this package, but instead allows you to opt-in to use grpc-js.

@slavovojacek
Copy link

Would like to see this in as well. The grpc package homepage features an official deprecation notice now, so it would be nice to switch to https://github.com/grpc/grpc-node/tree/master/packages/grpc-js.

Please let me know if I can help in any way to push this forward.

@117sparta
Copy link
Author
117sparta commented Aug 5, 2020

I guess i can close this pull request due to #236 .

@117sparta 117sparta closed this Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants