[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning in docs about #723 #766

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add warning in docs about #723 #766

merged 1 commit into from
Dec 13, 2023

Conversation

glatterf42
Copy link
Member
@glatterf42 glatterf42 commented Dec 13, 2023 •
edited
Loading

Since we won't be able to merge #723 in time, this PR adds a warning in the docs to where PRICE_EMISSION is defined. This will allow us to postpone the fix for 3.8.1 in January.

I'm actually not sure: should we update the release notes?

How to review

  • Read the diff and note that the CI checks all pass.
  • Check the documentation built by the RTD check below and look at MESSAGE core formulation -> Variable Definitions -> Auxiliary Variables.

PR checklist

  • Continuous integration checks all ✅
  • [ ] Add or expand tests; coverage checks both ✅ Only docs
  • Add, expand, or update documentation.
  • Update release notes.

@glatterf42 glatterf42 added the docs Documentation label Dec 13, 2023
@glatterf42 glatterf42 added this to the 3.8 milestone Dec 13, 2023
@glatterf42 glatterf42 self-assigned this Dec 13, 2023
@codecov Codecov
Copy link
codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

Merging #766 (56ffb93) into main (2d7b3f5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@          Coverage Diff          @@
##            main    #766   +/-   ##
=====================================
  Coverage   95.2%   95.2%           
=====================================
  Files         46      46           
  Lines       4312    4312           
=====================================
  Hits        4107    4107           
  Misses       205     205

khaeru
khaeru approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member
@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I don't think we need to add it to the release notes.

@glatterf42 glatterf42 merged commit 6b4f630 into iiasa:main Dec 13, 2023
18 checks passed
@glatterf42 glatterf42 deleted the warn/price-emission branch December 13, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaeru khaeru khaeru approved these changes

Assignees

@glatterf42 glatterf42

Labels
docs Documentation
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
2 participants
@glatterf42 @khaeru