[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PETSc options contamination between multiple preconditioners in multi-system #29063

Open
GiudGiud opened this issue Nov 13, 2024 · 4 comments
Open

PETSc options contamination between multiple preconditioners in multi-system #29063

GiudGiud opened this issue Nov 13, 2024 · 4 comments
Assignees
@lindsayad
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@GiudGiud
Copy link
Contributor
GiudGiud commented Nov 13, 2024 •
edited
Loading

Bug Description

-ksp_type
-snes_test_jacobian
when passed to the second PC object get passed to the first one as well.

Same for solve_type but that's likely a different cause. It would be nice though

Steps to Reproduce

petsc_options_iname_prec = '-pc_type -ksp_type'
petsc_options_value_prec = 'lu preonly'

[Preconditioning]
  [flow]
    type = SMP
    #  solve_type = NEWTON
    trust_my_coupling = true
    full = true
    nl_sys = "nl0"
    petsc_options_iname = '-pc_type -pc_factor_shift_type -pc_factor_mat_solver_package'
    petsc_options_value = 'lu NONZERO superlu_dist'
  []
  [scalar1]
    type = SMP
    # solve_type = LINEAR
    nl_sys = "prec1"
    petsc_options = '-snes_test_jacobian'
    petsc_options_iname = ${petsc_options_iname_prec}
    petsc_options_value = ${petsc_options_value_prec}
  []

Impact

Makes debugging multi-system problems difficult

[Optional] Diagnostics

No response
@GiudGiud GiudGiud added T: defect An anomaly, which is anything that deviates from expectations. P: normal A defect affecting operation with a low possibility of significantly affects. labels Nov 13, 2024
@lindsayad
Copy link
Member

we will need to add options prefixes for the different systems

@lindsayad
Copy link
Member

Are you going to work on this or should I assign myself?

@GiudGiud
Copy link
Contributor Author

if you already know what to do please go ahead

@lindsayad lindsayad self-assigned this Nov 13, 2024
@lindsayad lindsayad moved this to Todo in NEAMS MP TA 2025 Nov 13, 2024
@lindsayad
Copy link
Member

Related to #24690

lindsayad added a commit to lindsayad/moose that referenced this issue Nov 14, 2024
@lindsayad
Demonstrate multiple preconditioner blocks
08c0cd3 
Closes idaholab#24690 idaholab#29063
lindsayad added a commit to lindsayad/moose that referenced this issue Nov 14, 2024
@lindsayad
Demonstrate multiple preconditioner blocks
e4c5e17 
Closes idaholab#24690 idaholab#29063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lindsayad lindsayad

Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
NEAMS MP TA 2025
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lindsayad @GiudGiud