[go: up one dir, main page]
Skip to content
This repository has been archived by the owner on Apr 13, 2021. It is now read-only.

Add repository key to package.json #41

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Add repository key to package.json #41

merged 2 commits into from
Mar 10, 2021

Conversation

addison-grant
Copy link
Member

This will hopefully prevent dependabot from posting incorrect links.

@addison-grant
Add repository key to package.json
4d5df54 
This will hopefully prevent dependabot from posting incorrect links.
@addison-grant
Add missing comma
a54f17a
@addison-grant
Copy link
Member Author

This came up in https://github.com/iFixit/ifixit/pull/36604.

@addison-grant
Copy link
Member Author
addison-grant commented Mar 10, 2021 •
edited
Loading

QAing

  • Maybe run the json file through a JSON parser like jq to make sure it is properly formatted
  • Maybe check the npm package.json docs to make sure it's properly formatted
  • See if NPM or someone has a pacakge.json validator
  • This should be pretty safe.

@GrantMatejka
Copy link

CR 🌽

@addison-grant
Copy link
Member Author

Checked the JSON form with https://jsonlint.com/

image

Did a spell check with a Google search.

The repo address was a copy-paste from https://github.com/iFixit/formy

I don't think there's really too much to worry about. QA ☀️

@davidrans
Copy link
Member

CR ☕

@addison-grant addison-grant merged commit 97e7e81 into master Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addison-grant @GrantMatejka @davidrans