8000 Fix a bug in the handling of C strings. by tmroeder · Pull Request #6 · hlslibs/ac_types · GitHub
[go: up one dir, main page]

Skip to content

Fix a bug in the handling of C strings. - #6

Open
tmroeder wants to merge 1 commit into
hlslibs:masterfrom
tmroeder:fix-ac-int
Open

tmroeder wants to merge 1 commit into
hlslibs:masterfrom
tmroeder:fix-ac-int

Conversation

@tmroeder
Copy link
Copy Markdown

The while loop will never exit due to the check while(str), since str
will never become null by increment. This should be checking the
character pointed to by str.

The while loop will never exit due to the check `while(str)`, since str
will never become null by increment. This should be checking the
character pointed to by str.
@mariamfla
< 8DD5 div class="timeline-comment-actions flex-shrink-0 d-flex flex-items-center">
Copy link
Copy Markdown

Can I ask you please, why for ac_int , the width of the division result is the addition of the divided and dividor widths (W1+W2) as written in the pdf, table #9?
shouldn't it be the max of the two "Max(W1,W2)"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0