8000 Solaris 11 compatibility by senjan · Pull Request #914 · hishamhm/htop · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Solaris 11 compatibility - #914

Open
senjan wants to merge 3 commits into
hishamhm:masterfrom
senjan:master
Open

Solaris 11 compatibility#914
senjan wants to merge 3 commits into
hishamhm:masterfrom
senjan:master

Conversation

@senjan
@senjan senjan commented May 27, 2019
Copy link
Copy Markdown

This PR aims to address 2 issues with htop on current Solaris:

  1. htop does not build because Solaris's sys/sysinfo.h defines CPU_KERNEL which collides with definition within htop
  2. when run in a Non-Global Zone, kstat module "zones" is not available thus kstat_lookup() returns NULL making htop to crash due to NULL pointer dereference in SolarisProcessList_readZoneName().

@senjan
senjan commented May 30, 2019
Copy link
Copy Markdown
Author

fixed missing symbol when building on Linux

@ghost
ghost commented May 31, 2019
Copy link
Copy Markdown

Thanks, @senjan - good catch. Keeping track of changes on both illumos and Oracle Solaris can be quite a chore. Contributions are always appreciated!

@RobCrowston
RobCrowston commented Jun 6, 2019
Copy link
Copy Markdown

@dodona2 Solaris 11.4 is only nine months old. There are still pockets of industry users out there.

@natoscott
natoscott commented Aug 20, 2020
Copy link
Copy Markdown
Collaborator

Merged here: htop-dev/htop@b30c22d (though I renamed the somewhat cryptic "CPU_KRNL" to "CPU_SYSTEM")

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@senjan @RobCrowston @natoscott
0