Repository navigation
Conversation
This was just occurring with the jvm ByteBuffer implementations.
Owner
|
Indeed, you seem to be right. I believe this is an artifact that escaped tests. Some time ago, the position of a view with an offset was not 0 and it needed that kind of special support. It's merged on develop. I'll improve the tests and merge on main, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggesti
31E5
ons cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
This just makes the impl of
binf.protocol/-IByteBufferforByteBufferthe same as the existing impl forDirectByteBuffer. I am not quite seeing what addition of the.arrayOffsetwas doing for things but I may well be missing something!With this change I think many uses of
(binf.protocol/-array-index this position)can just be replaced withposition.