Repository navigation
fix(init): stop naming a language from files inside dependency directories - #201
Open
tuyentran4992 wants to merge 1 commit into
Open
tuyentran4992 wants to merge 1 commit into
tuyentran4992 wants to merge 1 commit into
Conversation
…ories `init` fed the raw `git ls-files` output to language detection, so a single `.php` file inside a `node_modules` that `.gitignore` does not cover was enough to name php. The init path now drops `node_modules`, `vendor`, `site-packages`, `.venv` and `venv` before detection, while a PHP source outside those directories is still named php.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #136.
inithanded the rawgit ls-filesoutput straight to language detection, so a single.phpfile inside anode_modulesthat.gitignoredoes not cover (orvendor,site-packages,.venv,venv) was enough to name php — the same files the active plugins' ownfilesglobs already leave out.The init path now drops files inside those directories before detection: no language is named from a file that only sits in one of them, a real PHP source elsewhere in the project still names php, and a file that merely resembles one of the names (
src/vendorize.py) still names its language.Test:
tests/test_init_names_no_language_from_dependency_directories.py— one case per dependency directory, a real source file beside it, and bothdone whencases from the issue. Running alongside the existing init, recommend, report and listing tests: 6 failed / 41 passed before the change, 47 passed after.