Repository navigation
feat(config): enforce required habit-hooks version - #196
Merged
Merged
Conversation
Collaborator
|
The CI run failed for this PR. Please also note that normally we accept PRs if people get the issue assigned to them first after a short conversation on the issue. I'm willing to skip that requirement, since the PR is small and seems well done, but the CI run still needs to be fixed. |
Contributor
Author
|
Thanks for the heads-up. I moved the version requirement validation into a focused helper so load_config stays below the Ruff PLR0915 threshold. The update is pushed; CI should rerun on the new commit. |
devill
approved these changes
Sep 25, 2026
Collaborator
|
Thanks for the PR! Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the root requires config key and validates it as a PEP 440 version specifier. Configuration loading refuses an unmet floor before sensors are configured, with an error naming both the requirement and running version. Invalid requirements are refused instead of ignored. Validation: 38 focused config/CLI tests passed; git diff --check passed. Closes #110.