8000 Tag row tint, search focus fix, context menu submenu fix by fsoft72 · Pull Request #383 · hyprlab/hylki · GitHub
[go: up one dir, main page]
Skip to content

Tag row tint, search focus fix, context menu submenu fix - #383

Closed
fsoft72 wants to merge 3 commits into
hyprlab:mainfrom
fsoft72:background-color
Closed

Tag row tint, search focus fix, context menu submenu fix#383
fsoft72 wants to merge 3 commits into
hyprlab:mainfrom
fsoft72:background-color

Conversation

@fsoft72
@fsoft72 fsoft72 commented Oct 8, 2026
Copy link
Copy Markdown
Contributor

Summary

  • Tagged rows are tinted. A message with at least one tag gets a light wash (18%, 28% on hover) of the tag's color behind its row in the message list. The first tag in Settings order wins. Selected rows keep their own look.
  • Search no longer closes when focus moves to the scope picker. An empty search closed on focus-out, so clicking "All folders" closed it instead of opening the dropdown. Focus moving to another widget of the same row (dropdown, popup, buttons) now keeps it open. Same fix for "Find in message" in the reader.
  • Context menu submenus open again. On X11 (GTK 4.20), GTK's popover autohide deactivated the window on the first press inside the menu and then closed it, so clicking Tags shut the whole menu. Context menus now have autohide off and close by hand: Esc, a press elsewhere in the window, or the window losing focus.

Changes

  • src/ui/message_row.rs, src/app.rs: rowtint-<tag class> class on the row host and the matching CSS rules.
  • src/ui/mod.rs: new close_if_focus_left_row helper, used by message_list.rs and message_view.rs.
  • src/ui/context_menu.rs: set_autohide(false) and dismiss_on_outside_action.
  • CHANGELOG.md: one entry per change.

Test plan

  • Tag a message: its row is tinted, text stays readable, selection and hover look right (light and dark theme).
  • Open search, click "All folders": the dropdown opens and the search stays open. Click on the list: an empty search still closes.
  • Right-click a message, click Tags: the submenu opens; pick a tag; back arrow works.
  • Context menu closes on Esc, on a click outside, on Alt+Tab; right-click on another row while a menu is open opens that row's menu.
  • Bulk menu (multi-selection) and the bulk Tags button behave the same.

Not covered

Native GtkDropDown and MenuButton popovers keep GTK's own autohide. If one of them still closes on click, it needs its own fix.

@fsoft72 fsoft72 mentioned this pull request Oct 8, 2026
Closed
5 tasks
@hyprlab
hyprlab commented Oct 10, 2026
Copy link
Copy Markdown
Owner

Tagged rows accent wash is a great addition, so is the search fix. I have incorporated both however, the context menu change is rejected as it would alter the way the context menu is handled under Wayland for the sake of X11. I may revisit this as an X11-only change in the future.

hyprlab added a commit that referenced this pull request Oct 10, 2026
@hyprlab @fsoft72
fix(search): keep an empty search open within its row (#383)
785f593 
An empty search closed on focus-out, so the folder scope picker beside it could not be opened.

Co-Authored-By: Fabio Rotondo <2844375+fsoft72@users.noreply.github.com>
hyprlab added a commit that referenced this pull request Oct 10, 2026
@hyprlab @fsoft72
feat(list): tint the row of a tagged message with its tag color (#383)
6816ac3 
Settings → Message List → Tint tagged messages, off by default. The row carries its class either way; only the CSS rules follow the setting.

Co-Authored-By: Fabio Rotondo <2844375+fsoft72@users.noreply.github.com>
@hyprlab hyprlab closed this Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fsoft72 @hyprlab
0