Repository navigation
Conversation
Bcc recipients go to gpg as hidden recipients, so To and Cc cannot see whose keys were Bcc'd. A good signature from a key without the From address shows amber, not green. Encrypting to a key the keyring does not vouch for asks first in the composer, and each address is encrypted to the checked key by fingerprint, preferring a vouched one.
An account can now send its key in an Autocrypt header and keep the keys others send, gossip included, in a keyring of Hylki's own rather than the user's GnuPG keyring. Recipients are looked up by WKD while a message is addressed, each pill shows where its key comes from, and Encrypt turns on when everyone prefers it.
A draft of a message set to be encrypted was saved readable to the server and to the local draft cache. It is now encrypted to the user's own key alone, unsigned, with its subject and recipients inside and an Autocrypt-Draft-State header outside, on IMAP, JMAP and Microsoft 365. Opening it again decrypts it off the main thread and opens the composer with Encrypt on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #602.
Drafts of a message marked Encrypt were saved in plaintext to the server and the
draft_copiescache. They are now encrypted to the user's own key (not signed), with subject and recipients inside andAutocrypt-Draft-State: encrypt=yesoutside, on the IMAP, JMAP and Graph draft paths. Reopening decrypts on a background thread and opens the composer with Encrypt on.Tests: the round trip through the draft cache with a throwaway keyring. Not tested live: whether Exchange stores a PGP/MIME draft intact.