Repository navigation
Conversation
Opening an attachment hands it to the desktop's default handler. A .desktop, shell script, AppImage, jar, Windows binary and similar, or a file whose first bytes are ELF, MZ or a shebang whatever its name, now asks first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening an attachment hands it to the desktop's default handler, which for a
.desktopfile, a shell script or an AppImage means running it. Hylki now asks first, with the existing destructive-confirm dialog, when the name ends in one of about 50 risky extensions (.desktop,.sh,.AppImage,.jar,.exe, macro-enabled Office files, ...) or the first bytes are an ELF or Windows binary or a#!script.Tests: the risky-name and magic-bytes table.