Repository navigation
Conversation
Export settings wrote the bundle with umask permissions and each account's OAuth client secret. It is now written 0600 without the secrets, and an import keeps the secret already on this computer for the same address and client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings export included each account's OAuth
client_secretand was written with umask permissions. It is now written 0600 (throughwrite_private) and leaves client secrets out; importing on the same computer puts back the secret it already has for the same address, client id and token URL.Not included: moving
client_secretfromaccounts.tomlinto the keyring, which needs a load-time migration like the oldpasswordone.Tests: removing and restoring client secrets; the settings-bundle golden.