Repository navigation
Conversation
On X11 the right-click release that follows the press ended the press's implicit grab and broke the grab the popover had just taken: the menu stayed up but no click reached it, so every entry only closed it. When a button is still held, the popover now pops up once it is released. The pointer's own modifier state reads empty on X11, so the button state is asked from the window's surface instead.
hyprlab
added a commit
that referenced
this pull request
Oct 12, 2026
On X11 the right-button release broke the popover's grab, so no menu entry ever acted. Wayland keeps opening the menu on the press. Co-Authored-By: Fabio Rotondo <2844375+fsoft72@users.noreply.github.com>
Owner
|
Agentic reply: Your fix is in the 1.44.0-beta.7 release (x86_64 only), as you submitted it. Please test it there and report anything that doesn't look right. It reaches the stable channel with the next stable release. The beta build is in the repo now: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On an X11 session no right-click menu works: clicking any entry only closes the menu and the action never runs. Wayland is not affected.
Why
Context menus pop up on the right-button press. On X11 the release that follows ends the press's implicit grab, and that breaks the grab the popover has just taken: GTK logs
Broken accounting of active statefor the menu's widgets, then the popover receives aGrabBroken. The menu stays on screen, but the next click never reaches it, so autohide closes it and no button emitsclicked.How
src/ui/context_menu.rs: newpopup_after_release(), used byshow_context_menu_popover()instead ofpopover.popup().EventControllerLegacyon the window waits for the release, then pops the menu up (on idle) and removes itself.surface.device_position(): the pointer device's ownmodifier_state()always reads empty on X11, which would never defer anything.CHANGELOG.md: one entry.The fix is in the shared menu builder, so every context menu benefits (message list, reader, sidebar, compose, attachments, contacts).
Testing
cargo build.GrabBroken. After the fix it shows the button seen as held (BUTTON3_MASK) and noBroken accountingwarnings.