Repository navigation
Conversation
hyprlab
added a commit
that referenced
this pull request
Oct 11, 2026
The prefix check sliced a folder path at a byte offset that could fall inside a multibyte character and crash at startup. Co-Authored-By: Elliot <115418645+Elliot-32@users.noreply.github.com>
hyprlab
added a commit
that referenced
this pull request
Oct 11, 2026
Owner
|
Agentic reply: Your fix is in the 1.44.0-beta.4 release (x86_64 only), as you submitted it. Please test it there and report anything that doesn't look right. It reaches the stable channel with the next stable release. The beta build is in the repo now: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hylki 1.43.1 crashes on startup when a custom folder path has a multibyte character crossing byte offset 6.
folder_namespace()slices atroot.len()after checking only the byte length. A synthetic path such asabcd摘要reproducesend byte index 6 is not a char boundary.Change
Use
str::get()for the prefix check, preserving ASCII case-insensitive matching. Extract namespace inference into a helper so the regression test exercises production logic without initializing GTK. Cover UTF-8 boundaries, INBOX prefixes and delimiters, mixed folders, short paths, and empty inputs.Validation
cargo test --locked folder_namespace_handles_utf8_paths: passed.cargo build --locked: passed in the GNOME 50 SDK with the installed Flatpak libraries.33080d3and launched in the existing Flatpak environment on CachyOS/niri: account loaded, window opened, no UTF-8 panic. The original 1.43.1 install reproduces the crash.