Repository navigation
ci: fail on pending Ash code generation - #684
Merged
Merged
Conversation
The test job never ran `mix ash.codegen --check`, so a dependency bump that needs a migration (ash_postgres 2.14's ash_functions v7) passed CI with the migration missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI now runs
mix ash.codegen --checkin the test job, right after compile, so resources that have drifted from their checked-in migrations, snapshots or generated code fail the build.Nothing caught that #682 (ash_postgres 2.14) needed a new
ash_functionsv7 migration; tests still passed because nothing exercised the broken path. The check passes on main and on the current head of #682.It runs inside the existing test job, so the CI gate's
needslist is unchanged.