This repository was archived by the owner on Jun 13, 2026. It is now read-only.
Repository navigation
add extract_file_to_string - #8
Merged
Merged
Conversation
Owner
|
Thanks mate, I'll take a look at it when I have a chance and hopefully merge it without issues. Been a bit busy with RL lately, but will try to remember... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The major goal of this PR is to add proc
extract_file_to_string()proc to bypass file creation step.Unfortunately I have found that
mz_zip_archive_file_stat()proc doesn't work becausemz_zip_archive_file_statobject is inside importc push block, so I had to break up importc block.Also I have found that
mz_zip_reader_extract_to_callback()doesn't work becausemz_file_write_funcproc type doesn't have calling connevntion specified, fixed it as well.Summary of changes
extract_file()andextract_file_to_string()into new functionfile_index_inexact().file_index_inexact()is private function not exported.extract_file_to_string()