Allow setting WKT options or disabling WKT options entirely. #152
Conversation
|
Fixes #153 |
|
Testing now (MariaDB 15.1) and working as expected. |
|
@grimzy, will this request be merged? Install package and got this error with parameters count, don't know what to do |
|
I'm waiting a merge of this pull request too |
|
This would be really helpful! |
|
This would be nice indeed. Any plans of looking this over and perhaps merging @grimzy? |
|
same, merge is strongly needed |
|
please add this |
|
please add this :( |
|
No activity on the master branch since Oct 2020. Looks like @grimzy might have abandoned the project. |
|
My problem is related to two Issues at once (this one, about wktOptions with MariaDB, and another one, with Laravel 9.x Compatibility). So the solution is to make it work with Laravel 9.x + MariaDB 10.x
You can use this solution, while we hope that the @grimzy will have some time to build version for Laravel 9 with wktOptions ;) |
MySQL allows 3 parameters, MariaDB only two: - https://dev.mysql.com/doc/refman/8.4/en/gis-wkt-functions.html#function_st-geomfromtext - https://mariadb.com/kb/en/st_geomfromtext/ Related: grimzy#152 Related: grimzy#138
MySQL allows 3 parameters, MariaDB only two: - https://dev.mysql.com/doc/refman/8.4/en/gis-wkt-functions.html#function_st-geomfromtext - https://mariadb.com/kb/en/st_geomfromtext/ Related: grimzy#152 Related: grimzy#138
MySQL allows 3 parameters, MariaDB only two: - https://dev.mysql.com/doc/refman/8.4/en/gis-wkt-functions.html#function_st-geomfromtext - https://mariadb.com/kb/en/st_geomfromtext/ Related: grimzy#152 Related: grimzy#138
Unlike MySQL, the WKT-input spatial analysis functions in MariaDB like
ST_GeomFromTextandST_DISTANCEdo not take an options parameter: https://mariadb.com/kb/en/st_geomfromtext/If I understand correctly, we need to pass "
axis-order=long-lat" because otherwise some versions of MySQL will interpret coordinate pairs as lat-long. For MariaDB, this is not necessary because MariaDB reads WKT values as long-lat by default.In its current state, using this package with MariaDB will throw the following exception when trying to insert or update values for a spatial column, because we force the third options parameter in
ST_GeomFromText:This is because the MariaDB function expects at most two arguments: https://github.com/MariaDB/server/blob/cf87f3e08c10dd7a944447ddee93fbc3827e6570/sql/item_geofunc.cc#L2993
This PR adds the option to set a
$wktOptionsproperty on the model that will overwrite the default options "axis-order=long-lat". It can be set to false to remove the options parameter entirely, which fixes the errors when using MariaDB.Additionally, it adds flexibility for users that may want or need to change the WKT options for whichever reason.
This is completely backwards-compatible, because if
$wktOptionsis not set, it will default to "axis-order=long-lat".