Fixes geometry values on created event #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grimzy Any idea why the tests fail, looking at it, it might be that model events do not work in tests. I'm trying to run the tests locally but I get |
Updated event is fired before saved. So to make this work on observers observing the updated event we need to invoke on the updated event instead of the saved event.
|
@Dylan-DutchAndBold : thank you for the PR. Regarding tests, maybe this will help: https://laravel.com/docs/5.7/mocking#event-fake |
|
This PR is absolutely needed! I've tested it in my project and it perfectly solved the geometries issues on save/create events. For now to implement this I've extended SpatialTrait to create a custom one with this PR's change into its bootTrait method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #70