[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report Cloud runs aborted by thresholds with exitcodes.ThresholdsHaveFailed #3923

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Report Cloud runs aborted by thresholds with exitcodes.ThresholdsHaveFailed #3923

merged 1 commit into from
Aug 29, 2024

Conversation

joanlopez
Copy link
Contributor

What?

It's a follow up from #3876.

It also takes into account testProgress.RunStatus == cloudapi.RunStatusAbortedThreshold as a reason for return errext.WithExitCodeIfNone(errors.New("Thresholds have been crossed"), exitcodes.ThresholdsHaveFailed).

Why?

Because when thresholds are configured with abortOnFail: true, and thresholds are crossed, then testProgress.RunStatus == cloudapi.RunStatusAbortedThreshold.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@joanlopez joanlopez added this to the v0.54.0 milestone Aug 28, 2024
@joanlopez joanlopez self-assigned this Aug 28, 2024
@joanlopez joanlopez requested a review from a team as a code owner August 28, 2024 13:19
@joanlopez joanlopez requested review from codebien and olegbespalov and removed request for a team August 28, 2024 13:19
codebien
codebien approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor
@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joanlopez Can you check #2804 and integrate it with the new changes if they are missing there, please?
It would be good to have it tracked as a diff like before: / after:

@joanlopez
Copy link
Contributor Author

@joanlopez Can you check #2804 and integrate it with the new changes if they are missing there, please? It would be good to have it tracked as a diff like before: / after:

Sure, I'd be happy to do a full scan of all the scenarios mentioned there, and see if there's any quick improvement, as with ThresholdsHaveFailed. But, do you mind if I merge this pull request, and do that in another one, please?

@codebien
Copy link
Contributor

@joanlopez I meant to update the issue with the changes from this current pull request. If you want to do more that's great but I didn't expect that.

@joanlopez joanlopez mentioned this pull request Aug 29, 2024
Open
@joanlopez joanlopez merged commit 1870fad into master Aug 29, 2024
22 checks passed
@joanlopez joanlopez deleted the cloud-thresholds-abort branch August 29, 2024 08:51
@BrewTestBot BrewTestBot mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegbespalov olegbespalov olegbespalov approved these changes

@codebien codebien codebien approved these changes

Assignees

@joanlopez joanlopez

Labels
None yet
Projects
None yet
Milestone
v0.54.0
Development

Successfully merging this pull request may close these issues.
3 participants
@joanlopez @codebien @olegbespalov