8000 fix: reset the registries by owulveryck · Pull Request #467 · gorgonia/gorgonia · GitHub
[go: up one dir, main page]

Skip to content

fix: reset the registries - #467

Merged
owulveryck merged 5 commits into
masterfrom
tapeemachine/fixreset
Jan 24, 2021
Merged

owulveryck merged 5 commits into
masterfrom
tapeemachine/fixreset

Conversation

@owulveryck
Copy link
Copy Markdown
Member

No description provided.

@owulveryck
Copy link
Copy Markdown
Member Author

This should fix #466

@dcu
dcu commented Jan 23, 2021
Copy link
Copy Markdown
Collaborator

this fixes and issue I was struggling with, thanks Olivier

@dcu
dcu commented Jan 23, 2021
Copy link
Copy Markdown
Collaborator

is it possible to write a test for this ?

@owulveryck
Copy link
Copy Markdown
Member Author

is it possible to write a test for this ?

I agree with you, I'd like to write a test before actually merging the PR.
It is easy to reproduce with agogo (see https://github.com/gorgonia/agogo/blob/ce6073931e2c36f2986cd1048fc89ceb80c7df7a/dualnet/dual_test.go#L17) but the graph is big, and it is not easy to find the root cause.
I am still investigating.

@chewxy
chewxy commented Jan 24, 2021
Copy link
Copy Markdown
Member

This is straightforwards and correct IMO.

@owulveryck
owulveryck merged commit 531c6df into master Jan 24, 2021
@owulveryck
owulveryck deleted the tapeemachine/fixreset branch January 24, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0