8000 Update libkrun to 1.19.6 by gominimal-pkgmgr-mgr[bot] · Pull Request #835 · gominimal/pkgs · GitHub
[go: up one dir, main page]
Skip to content

Update libkrun to 1.19.6 - #835

Merged
bryan-minimal merged 2 commits into
mainfrom
update-libkrun-1.19.6
Oct 9, 2026
Merged

Update libkrun to 1.19.6#835
bryan-minimal merged 2 commits into
mainfrom
update-libkrun-1.19.6

Conversation

@gominimal-pkgmgr-mgr
@gominimal-pkgmgr-mgr gominimal-pkgmgr-mgr Bot commented Oct 8, 2026
Copy link
Copy Markdown
Contributor

Update libkrun 1.19.4 → 1.19.6

Source: github:containers/libkrun:operator-pinned
Release: https://github.com/containers/libkrun/releases/tag/v1.19.6
Changelog: libkrun/libkrun@v1.19.4...v1.19.6
Released: 9 days ago (2026-09-29)

Pkgscan: clean — diff against the prior version surfaced no newly-introduced suspicious patterns.

Components changed

CycloneDX component delta (declared materials — the package's own version, not a dependency-tree diff)
Component Old New
~ libkrun 1.19.4 1.19.6
~ libkrun-upstream 1.19.4 1.19.6

Changes

Old New
Version 1.19.4 1.19.6
SHA256 e8775fab2b460972... 7025d72208172dc0...
Size 1.8 MB
Source https://github.com/containers/libkrun/archive/refs/tags/v1.19.4.tar.gz https://github.com/containers/libkrun/archive/refs/tags/v1.19.6.tar.gz
  • License: Apache-2.0 (source: GitHub + tarball)

Quality suggestions

  • Missing tests block. This package has no standalone tests, so the buildbot will only verify compilation — not functional correctness. Consider adding a minimal smoke test (e.g., a --version or small round-trip invocation) as part of this PR so future bumps catch regressions. See packages/python/build.ncl for a simple example.

Created by pkgmgr

@coderabbitai
coderabbitai Bot commented Oct 8, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: gominimal/pkgs/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6b2faeb9-5c5c-47ba-8f6a-cfe9b961d7f5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@mitodrummer mitodrummer mentioned this pull request Oct 8, 2026
Merged
@mitodrummer
mitodrummer commented Oct 8, 2026
Copy link
Copy Markdown
Member

Heads-up before this merges: 1.19.6 brings real vsock fixes (b13ddc5b releases proxies after a clean shutdown; d2d8dd66 removes refused connections without waiting for the reaper), but it does not fix the VMM abort in gominimal/minimal#2103.

In 1.19.6, src/devices/src/virtio/vsock/muxer.rs (~L563–573) still does UnixProxy::new(...).unwrap(). When the host can't create the socket for a guest-to-host stream (EMFILE/ENFILE/ENOBUFS), the panic aborts the whole VMM. We hit it twice on a macOS host during a heavy guest build. The Linux path is the same code, so a Linux host can hit it too.

The macOS side is fixed in gominimal/minimal#2105, which carries vendor/libkrun/patches/0002-vsock-refuse-stream-when-unix-proxy-creation-fails.patch: on error it logs and sends the guest an RST for that one stream instead of aborting. It applies cleanly on v1.19.6 after 0001.

Suggest carrying the same patch here, the way this package already carries 0001:

Both patches get dropped once upstream releases the fixes (the 0002 report is going to containers/libkrun). Happy to push that to this branch if that's easier.

@bryan-minimal @claude
libkrun: carry the vsock unix-proxy refusal patch (minimal#2103)
dc98b32 
1.19.6 still unwraps UnixProxy::new() for a guest-to-host stream, so a
transient EMFILE/ENFILE/ENOBUFS on the host aborts the whole VMM. Carry
0002 from gominimal/minimal#2105 (identical file): log and answer that
stream with OP_RST instead. Applies cleanly on v1.19.6 after 0001.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal marked this pull request as ready for review October 8, 2026 19:54
@bryan-minimal
bryan-minimal requested a review from a team as a code owner October 8, 2026 19:54
@bryan-minimal
bryan-minimal commented Oct 8, 2026
Copy link
Copy Markdown
Member

@mitodrummer Thanks, done in dc98b32, as you laid out:

Checked against the real v1.19.6 tree: 0001 then 0002 apply cleanly, with no fuzz or rejects. Both get dropped once upstream releases the fixes.

@mitodrummer
mitodrummer commented Oct 8, 2026
Copy link
Copy Markdown
Member

Correction to my earlier comment: minimal's minvmd doesn't consume this package on Linux. It builds a static musl libkrun from its own vendor/libkrun/libkrun.lock pin plus vendor/libkrun/patches/ (scripts/build-libkrun-linux.sh), so gominimal/minimal#2105 covers the vsock abort for both platforms. Carrying 0002 here is still reasonable for anyone else using this package, but it isn't needed for minimal, and it shouldn't block this bump.

@bryan-minimal
bryan-minimal added this pull request to the merge queue Oct 9, 2026
Merged via the queue into main with commit 28d2302 Oct 9, 2026
11 checks passed
@bryan-minimal
bryan-minimal deleted the update-libkrun-1.19.6 branch October 9, 2026 00:42
This was referenced Oct 26, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitodrummer mitodrummer mitodrummer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mitodrummer @bryan-minimal
0