Repository navigation
dotenvx@2.22.0 - #658
Merged
Merged
dotenvx@2.22.0#658
Conversation
Member
|
/build |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe dotenvx package build updates the release from Changesdotenvx release update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR only updates the dotenvx package version in a single build file, and no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
thanks @bryan-minimal |
cvince
pushed a commit
to capysc/pkgs
that referenced
this pull request
Oct 2, 2026
…tpoint (gominimal#365) * microvm-rootfs: ship e2fsprogs + util-linux and /var/lib/minimal mountpoint Unblocks Unit 1 of the per-VM writable ext4 volume spec (gominimal/minimal gominimal#583, PR gominimal#658 R1.7). The guest minimald mounts a per-VM writable volume (/dev/vdb) at /var/lib/minimal, formats it with mkfs.ext4 on first boot, and reclaims space via discard/fstrim. The rootfs was missing all three pieces: - Promote e2fsprogs from a build-only dep (its files were stripped from the image) to the runtime closure, so mkfs.ext4/mke2fs ship in the guest. mke2fs stays on the build PATH via the injected runtime closure, so it still packs the image — the separate build_deps entry is now redundant and removed. - Add util-linux to the runtime closure for fstrim (space reclaim). - Stage /var/lib/minimal as an empty directory. The root is mounted read-only, so minimald cannot mkdir the mountpoint at runtime; it must ship in the image or the mount fails with ENOENT/EROFS. Image stays raw ext4 (rootfs.img); size grows ~26 MiB (from ~444 MB to ~472 MB). Verified in the built image: /var/lib/minimal is empty, mkfs.ext4 -V and fstrim --help resolve, filesystem TYPE=ext4. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * microvm-rootfs: canonicalize libblkid/libuuid to util-linux's versioned libs e2fsprogs and util-linux both ship a libblkid.so.1 and libuuid.so.1 with the same soname; the staging composition resolved them to e2fsprogs's older, unversioned forks. util-linux's libmount then loaded those and warned "libblkid.so.1: no version information available" on every fstrim/mount/blkid. Repoint both sonames at util-linux's versioned libs (an ABI superset — e2fsprogs's own mke2fs/e2fsck link them fine, verified by running a real mkfs.ext4 format) and drop the e2fsprogs forks. A guard fails the build if a package bump renames the util-linux targets so this can't silently regress. Verified in the rebuilt image: fstrim --help and mount -V emit zero stderr lines, mkfs.ext4 -V still resolves. Net image size drops ~175 KB. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
cvince
pushed a commit
to capysc/pkgs
that referenced
this pull request
Oct 2, 2026
…ominimal#366) * microvm-rootfs: ship e2fsprogs + util-linux and /var/lib/minimal mountpoint Unblocks Unit 1 of the per-VM writable ext4 volume spec (gominimal/minimal gominimal#583, PR gominimal#658 R1.7). The guest minimald mounts a per-VM writable volume (/dev/vdb) at /var/lib/minimal, formats it with mkfs.ext4 on first boot, and reclaims space via discard/fstrim. The rootfs was missing all three pieces: - Promote e2fsprogs from a build-only dep (its files were stripped from the image) to the runtime closure, so mkfs.ext4/mke2fs ship in the guest. mke2fs stays on the build PATH via the injected runtime closure, so it still packs the image — the separate build_deps entry is now redundant and removed. - Add util-linux to the runtime closure for fstrim (space reclaim). - Stage /var/lib/minimal as an empty directory. The root is mounted read-only, so minimald cannot mkdir the mountpoint at runtime; it must ship in the image or the mount fails with ENOENT/EROFS. Image stays raw ext4 (rootfs.img); size grows ~26 MiB (from ~444 MB to ~472 MB). Verified in the built image: /var/lib/minimal is empty, mkfs.ext4 -V and fstrim --help resolve, filesystem TYPE=ext4. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * microvm-rootfs: canonicalize libblkid/libuuid to util-linux's versioned libs e2fsprogs and util-linux both ship a libblkid.so.1 and libuuid.so.1 with the same soname; the staging composition resolved them to e2fsprogs's older, unversioned forks. util-linux's libmount then loaded those and warned "libblkid.so.1: no version information available" on every fstrim/mount/blkid. Repoint both sonames at util-linux's versioned libs (an ABI superset — e2fsprogs's own mke2fs/e2fsck link them fine, verified by running a real mkfs.ext4 format) and drop the e2fsprogs forks. A guard fails the build if a package bump renames the util-linux targets so this can't silently regress. Verified in the rebuilt image: fstrim --help and mount -V emit zero stderr lines, mkfs.ext4 -V still resolves. Net image size drops ~175 KB. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * e2fsprogs: defer libblkid/libuuid to util-linux (drop bundled forks) e2fsprogs bundles its own older forks of libblkid and libuuid with the same soname (libblkid.so.1, libuuid.so.1) as util-linux's maintained, symbol- versioned libraries. Any image that ships both — like microvm-rootfs — has the dynamic loader resolve util-linux's libmount against the wrong libblkid, warning "libblkid.so.1: no version information available" on every fstrim/mount/blkid. Configure e2fsprogs with --disable-libblkid --disable-libuuid --disable-uuidd (the standard distro config) so its tools link util-linux's libs — an ABI superset, verified by building and running a real mkfs.ext4 format + fsck.ext4 against them. e2fsprogs now builds no libblkid/libuuid/blkid/findfs/uuidgen; util-linux is the sole provider. pkgconf is added to build_deps because configure locates the system libs via pkg-config, and util-linux to build+ runtime deps. Cycle-safe: microvm-rootfs is the only importer of e2fsprogs, so nothing in util-linux's closure can reach it. This makes the microvm-rootfs libblkid/libuuid symlink-repointing hack from the previous commit redundant, so it's removed — the guest now gets a single, correct libblkid/libuuid and util-linux's modern blkid binary with no build.sh fixups. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * e2fsprogs: subset util-linux to libblkid/libuuid in runtime_deps Address CodeRabbit review on gominimal#366: e2fsprogs's tools only DT_NEED libblkid.so.1 and libuuid.so.1 from util-linux at runtime, so pull just those two outputs via subsetOf instead of the whole ~18 MB toolset — consumers of e2fsprogs no longer transitively inherit all of util-linux. build_deps keeps the full util-linux: configure detects the libs via pkg-config and needs the headers + .pc files (OutputData outputs, which subsetOf does not support), and build_deps do not propagate to consumers' runtime closures. Verified: min check missing_runtime_deps passes (DT_NEEDED satisfied by the subset), and the microvm-rootfs guest still has a single util-linux libblkid/libuuid, modern blkid, and a clean mkfs.ext4 + fsck.ext4. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bumps dotenvx to v2.22.0
Summary by CodeRabbit