8000 attrs: redistributable=false on the proprietary trio + minimum_version 0.0.18 (retry of #477) by bryan-minimal · Pull Request #656 · gominimal/pkgs · GitHub
[go: up one dir, main page]
Skip to content

attrs: redistributable=false on the proprietary trio + minimum_version 0.0.18 (retry of #477) - #656

Merged
bryan-minimal merged 3 commits into
mainfrom
attrs-redistributable-retry
Oct 26, 2026
Merged

attrs: redistributable=false on the proprietary trio + minimum_version 0.0.18 (retry of #477)#656
bryan-minimal merged 3 commits into
mainfrom
attrs-redistributable-retry

Conversation

@bryan-minimal
@bryan-minimal bryan-minimal commented Aug 27, 2026 •
edited by coderabbitai Bot
Loading
Copy link
Copy Markdown
Member

Re-lands #477's three attrs without the minimum_version bump, as an experiment: does the current consumer fleet survive a pure attr addition?

  • The 2026-07-28 victim was gominimal/webapp (their setup-mip action documents the repo-wide break). They've since migrated to mip from the minimal-one unstable channel and never evaluate the floating pkgs tip — only locked_commit.
  • A companion webapp draft PR bumps locked_commit to this branch's head so their full CI evaluates the attr'd catalog with their real toolchain. Green there = the modern channel tolerates the attr; red there = we still need the forward-compat stdlib work first.
  • Merge gate either way: the minimum_version / forward-compat choreography decision (see Revert #477: restore minimum_version 0.0.15, drop redistributable attr (unblock pinned-minimal consumers) #536's history and the compliance-coupling note — buildbot's NON_REDISTRIBUTABLE_NAMES fallback stays until the attr is live end-to-end).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Compatibility

    • Updated the minimum supported standard library version to 0.0.18.

  • Package Distribution

    • Android SDK, Claude Code, and EdgeDelta packages are now marked as non-redistributable. These packages may no longer be redistributed through supported package distribution workflows.

@bryan-minimal @claude
attrs: mark android-sdk, claude-code, edgedelta non-redistributable (…
845373c 
…retry of #477, experiment)

Same three attrs as #477, deliberately WITHOUT a minimum_version bump:
this branch exists to empirically answer 'does the current consumer
fleet survive an attr addition' — specifically gominimal/webapp, the
2026-07-28 victim (their setup-mip comment records the repo-wide
break), now migrated to mip from the minimal-one unstable channel. A
companion webapp draft PR points locked_commit at this commit so their
real CI renders the verdict. DO NOT MERGE until that verdict is green
and the minimum_version question is decided (see the stdlib bump
choreography discussion).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai
coderabbitai Bot commented Aug 27, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

Warning

Review limit reached

  • Run on-demand review

This review includes 4 billable files and costs up to $1.00.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 53 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 65 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: gominimal/pkgs/.coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 947b4482-9ab6-4b11-add4-1a0b3ac35793

📥 Commits

Reviewing files that changed from the base of the PR and between 1c52ed7 and a50f75a.

📒 Files selected for processing (4)
  • minimal.toml
  • packages/android-sdk/build.ncl
  • packages/claude-code/build.ncl
  • packages/edgedelta/build.ncl

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: gominimal/pkgs/.coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 64253a00-12f1-4676-a61f-af6056baf45f

📥 Commits

Reviewing files that changed from the base of the PR and between f152efe and 1c52ed7.

📒 Files selected for processing (4)
  • minimal.toml
  • packages/android-sdk/build.ncl
  • packages/claude-code/build.ncl
  • packages/edgedelta/build.ncl

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

📝 Walkthrough

Walkthrough

The minimum standard library version changed to 0.0.18. The Android SDK, Claude Code, and EdgeDelta package metadata now sets redistributable = false.

Changes

Runtime and package metadata

Layer / File(s) Summary
Standard library version requirement
minimal.toml		 The minimum standard library version changed from 0.0.15 to 0.0.18.
Package redistributability metadata
packages/android-sdk/build.ncl, packages/claude-code/build.ncl, packages/edgedelta/build.ncl		 The three package definitions now mark their artifacts as non-redistributable.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: twitchyliquid64

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because 8000 no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies both main changes: marking three packages as non-redistributable and raising minimum_version to 0.0.18.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@bryan-minimal @claude
stdlib: minimum_version 0.0.15 -> 0.0.18 (the full #477 shape)
1c52ed7 
The other half of the original #477: the gate that converts a raw
eval error on the new attr into a legible 'minimal too old'. 0.0.18
is still the current stdlib version at today's pins, so the modern
channel should clear it — that is precisely what the webapp probe
measures.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal commented Aug 27, 2026
Copy link
Copy Markdown
Member Author

Experiment result (webapp#727, closed with verdict recorded): 16/16 CI checks green against this branch's full shape — the attr AND the minimum_version 0.0.18 bump. Full-catalog dump, materialize, builds, and E2E all clean on the minimal-one unstable channel toolchain. The 2026-07-28 failure mode is empirically dead for the modern fleet.

Graduation checklist to take this from experiment → mergeable:

  1. Keep the minimum_version bump (it's the legible gate for whatever unmeasurable stragglers pin pre-0.0.18 channels — the population we can enumerate is green).
  2. Sequencing per Revert #477: restore minimum_version 0.0.15, drop redistributable attr (unblock pinned-minimal consumers) #536's compliance-coupling note: buildbot's is_redistributable already checks the attr first and keeps NON_REDISTRIBUTABLE_NAMES as the belt — no builder change required before merge, no re-exposure window.
  3. Announce the floor raise (brief, with the channel-update one-liner) before merging.

Un-draft when 3 is done.

@bryan-minimal
bryan-minimal marked this pull request as ready for review September 21, 2026 15:42
@bryan-minimal
bryan-minimal requested a review from a team as a code owner September 21, 2026 15:42
@bryan-minimal bryan-minimal changed the title attrs: redistributable=false on the proprietary trio (retry of #477 — CI experiment, do not merge) attrs: redistributable=false on the proprietary trio + minimum_version 0.0.18 (retry of #477) Sep 21, 2026
@bryan-minimal
bryan-minimal added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit bd1feab Oct 26, 2026
11 checks passed
@bryan-minimal
bryan-minimal deleted the attrs-redistributable-retry branch October 26, 2026 18:26
@bryan-minimal bryan-minimal mentioned this pull request Oct 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitodrummer mitodrummer mitodrummer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bryan-minimal @mitodrummer
0