Repository navigation
socat: add repology_project (un-blind the auto-update, #441) - #357
Merged
Merged
Conversation
socat's upstream (dest-unreach.org) is HTTP-only and fits no source_provenance category, so the version-checker resolved nothing and reported socat up-to-date while 1.8.1.1 sat behind stable 1.8.1.3 (CVE-2026-56123 HIGH, fixed in 1.8.1.2). Add `repology_project = "socat"` — repology reports newest = 1.8.1.3 — so the auto-update can discover the bump. The gs:// mirror re-fetch on bump is handled by pkgmgr's NAME_KEYED_UPSTREAMS (gominimal/pkgmgr-rs#449). Surfaced by the hidden-update audit: socat was the lone confirmed hidden security update among the directly-vulnerable packages. Refs gominimal/pkgmgr-rs#441. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe socat package build metadata adds a ChangesSocat Build Metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/socat/build.ncl`:
- Around line 50-55: The inline comment in the socat build metadata has a PR
reference mismatch and should be corrected to point to the actual companion
change. Update the reference in the comment near repology_project so it matches
the NAME_KEYED_UPSTREAMS change cited in the PR description, and ensure the
gominimal/pkgmgr-rs PR number is consistent throughout the note.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d6f9d9d8-e2b5-4f3a-a825-2b1f4639af5f
📒 Files selected for processing (1)
packages/socat/build.ncl
…(CR) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
twitchyliquid64
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
repology_project = "socat"so pkgmgr's version-checker can discover socat's upstream releases.Why
The hidden-update audit found socat is the lone confirmed hidden security update: pinned at
1.8.1.1, but stable upstream is1.8.1.3and1.8.1.2already fixes CVE-2026-56123 (HIGH — SOCKS5DOMAINNAMEheap overflow).socat's origin (
dest-unreach.org) is HTTP-only and fits nosource_provenancecategory (not GitHub/GNU/SF/GitLab), so the version-checker had no tier to resolve and silently reported it up-to-date. Repology tracks socat and reports newest =1.8.1.3, sorepology_projectis the right resolver.This is the auto-update-blind flavor of the #441 provenance gap — socat isn't vuln-scan-dark (it matches CVE-2026-56123), but the missing provenance cost us the fix.
Two-change fix (this is the pkgs half)
repology_projectfor version discovery.NAME_KEYED_UPSTREAMSentry so the gs:// mirror re-fetches the real tarball from dest-unreach.org on bump.Once both land + deploy, the auto-update system cuts the
socat → 1.8.1.3PR itself (clears CVE-2026-56123).Note
This PR only adds the resolver attr; it does not bump the version (socat stays 1.8.1.1). The bump comes from the auto-update system after this + #449 deploy. No source rebuild change.
Refs gominimal/pkgmgr-rs#441.
🤖 Generated with Claude Code
Summary by CodeRabbit