Repository navigation
microvm-rootfs: don't delete libssl with the e2fsprogs cleanup - #231
Merged
Merged
Conversation
The e2fsprogs lib-removal glob `libss*.so*` also matched openssl's
`libssl.so.3`, which socat links against — so the guest image shipped a socat
that failed at load ("libssl.so.3: cannot open shared object file") and never
emitted READY. Tighten to `libss.so*` (e2fsprogs's libss only); same for the
other two e2fs libs for precision. Verified: libssl.so.3 stays, libss.so/
libext2fs/mke2fs still excluded, and the image boots to READY.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe rootfs build script now removes only specific e2fs-related staging libraries using tightened glob patterns and includes a clarifying comment explaining the ChangesLibrary Pruning Refinement
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
mitodrummer
approved these changes
Jun 8, 2026
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #229. The e2fsprogs lib-removal glob
libss*.so*greedily matched openssl'slibssl.so.3(socat links it), so the builtmicrovm-rootfsimage shipped asocatthat failed at load:The guest init never emitted READY → microVM boot times out. Caught while wiring the downstream consumer to the merged package.
Fix: tighten the glob to
libss.so*(e2fsprogs'slibss.so.2only, notlibssl). Tightened the other two e2fs libs tolib<name>.so*for precision too.Verified against a rebuilt image:
libssl.so.3/libcrypto.so.3present, e2fsprogslibss.so/libext2fs/mke2fsstill excluded, and the image boots to READY under libkrun.🤖 Generated with Claude Code
Summary by CodeRabbit