8000 fish: fetch fluent-ftl-tools from GitHub while codeberg.org is down by bryan-minimal · Pull Request #1568 · gominimal/pkgs · GitHub
[go: up one dir, main page]

Skip to content

fish: fetch fluent-ftl-tools from GitHub while codeberg.org is down - #1568

Merged
bryan-minimal merged 1 commit into
mainfrom
fi 8000 sh-codeberg-mirror
Nov 18, 2026
Merged

bryan-minimal merged 1 commit into
mainfrom
fish-codeberg-mirror

Conversation

@bryan-minimal
@bryan-minimal bryan-minimal commented Nov 18, 2026 •
Copy link
Copy Markdown
Member

Why

lz4 (#1524) left the merge queue at 07:22Z with failed_checks. The queue build rebuilt fish, whose Rust compile fetches the fluent-ftl-tools git dependency from codeberg.org:

failed to resolve address for codeberg.org: Name or service not known
error: failed to get `fluent-ftl-tools` as a dependency of package `fish-fluent`

codeberg.org is currently NXDOMAIN at the .org registry's own nameservers: dig codeberg.org NS @v0n0.pir-ns.org +norecurse returns NXDOMAIN, while example.org answers normally. Resolvers with a cached record still work and the rest don't. Every queue run that rebuilds fish (lz4, gcc 16 #1545, …) fails until this is fixed or codeberg comes back.

Change

packages/fish/build.sh points git at the author's GitHub copy, github.com/danielrainer/fluent-ftl-tools, which has the pinned commit 5917664c8f2e4928ef1e480ff5c13bbe1e226066:

  • GIT_CONFIG_* env sets url.<github>.insteadOf <codeberg>, so no file is written.
  • CARGO_NET_GIT_FETCH_WITH_CLI=true, because cargo's built-in git client ignores insteadOf.

Cargo.lock is unchanged, and cargo still checks out the commit it pins, so the source is the same.

Follow-up

fish still has needs.internet: crates.io and three git dependencies are fetched at build time. A vendored-crates Source would make it hermetic. Upstream ships build_tools/make_vendor_tarball.sh but doesn't publish a vendor tarball.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the build setup to fetch a required build tool from its new repository source using Git. The existing lockfile pin remains in effect, so this change does not alter the selected version or affect app features.

codeberg.org is NXDOMAIN at the .org registry (2026-11-18), so fish's
cargo git fetch of fluent-ftl-tools failed and dropped lz4 (#1524) from
the merge queue. Rewrite the URL to the author's GitHub copy with git's
insteadOf; Cargo.lock's pinned commit 5917664c is still what is checked out.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 18, 2026 07:25
@coderabbitai
coderabbitai Bot commented Nov 18, 2026 •
Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The fish build script now configures Cargo to use the Git CLI and rewrites the fluent-ftl-tools repository URL from Codeberg to the author's GitHub repository. Comments state that Cargo still fetches the commit pinned in Cargo.lock.

Changes: Fish Cargo dependency fetch

Layer / File(s) Summary
Configure Cargo Git URL rewrite
packages/fish/build.sh
The build script configures Cargo to use the Git CLI and rewrites the fluent-ftl-tools URL to the author's GitHub repository.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: norrietaylor, agent-137

Merge Risk: Minimal · up to 933ae

This change redirects the fish build's fluent-ftl-tools fetch from Codeberg to a GitHub copy so builds survive the Codeberg outage. The pinned lockfile commit is unchanged, and no merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the change: fish fetches the fluent-ftl-tools dependency from GitHub while codeberg.org is down. The build.sh change rewrites the Codeberg URL to the author's GitHub copy, and the obje…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: fish fetches the fluent-ftl-tools dependency from GitHub while codeberg.org is down. The build.sh change rewrites the Codeberg URL to the author's GitHub copy, and the objectives describe the same goal. The title is specific and matches the main change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between befc43b and 933aed5.

Files selected for processing: 1

  • packages/fish/build.sh

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

@norrietaylor norrietaylor left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope matches the title. The diff adds one comment block and four export lines to packages/fish/build.sh. Clobber none: git log on packages/fish shows the cmake 4.5 install(SCRIPT CODE fix from #1526 is intact. Correctness git is in the build_deps of fish, so CARGO_NET_GIT_FETCH_WITH_CLI=true has a git binary to call. The GIT_CONFIG_COUNT/KEY_0/VALUE_0 form is correct, and insteadOf is a prefix match, so a .git suffix on the locked URL still matches. Cargo checks out the commit that Cargo.lock pins, so the redirect cannot change the source. The change is good. One nit: the workaround has no removal condition. Pattern packages/emacs-site-lisp/build.ncl fetches three Source archives from codeberg.org and has the same exposure if those archives are not cached. That file is not in this diff. Not checked The sandbox denied network access. I did not confirm that the fish 4.9.3 Cargo.lock spells the URL as https://codeberg.org/danielrainer/fluent-ftl-tools, or that the GitHub copy holds commit 5917664c. I did not confirm that the other two git dependencies of fish fetch correctly through the git CLI. A queue build of fish answers all three.

Comment thread packages/fish/build.sh
export CARGO_NET_GIT_FETCH_WITH_CLI=true
export GIT_CONFIG_COUNT=1
export GIT_CONFIG_KEY_0=url.https://github.com/danielrainer/fluent-ftl-tools.insteadOf
export GIT_CONFIG_VALUE_0=https://codeberg.org/danielrainer/fluent-ftl-tools
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit · The title says the redirect is for the time that codeberg.org is down, but the comment gives no removal condition. The redirect stays after codeberg.org returns, and the build then depends on a personal GitHub copy that upstream fish does not reference. Add one sentence that says when to remove these four lines, for example at the next fish version bump after codeberg.org resolves again. I found no other package with this redirect, so the fix is local.

@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit b96e6b3 Nov 18, 2026
16 checks passed
@bryan-minimal
bryan-minimal deleted the fish-codeberg-mirror branch November 18, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0