Repository navigation
fish: fetch fluent-ftl-tools from GitHub while codeberg.org is down - #1568
Conversation
codeberg.org is NXDOMAIN at the .org registry (2026-11-18), so fish's cargo git fetch of fluent-ftl-tools failed and dropped lz4 (#1524) from the merge queue. Rewrite the URL to the author's GitHub copy with git's insteadOf; Cargo.lock's pinned commit 5917664c is still what is checked out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
Scope matches the title. The diff adds one comment block and four export lines to packages/fish/build.sh. Clobber none: git log on packages/fish shows the cmake 4.5 install(SCRIPT CODE fix from #1526 is intact. Correctness git is in the build_deps of fish, so CARGO_NET_GIT_FETCH_WITH_CLI=true has a git binary to call. The GIT_CONFIG_COUNT/KEY_0/VALUE_0 form is correct, and insteadOf is a prefix match, so a .git suffix on the locked URL still matches. Cargo checks out the commit that Cargo.lock pins, so the redirect cannot change the source. The change is good. One nit: the workaround has no removal condition. Pattern packages/emacs-site-lisp/build.ncl fetches three Source archives from codeberg.org and has the same exposure if those archives are not cached. That file is not in this diff. Not checked The sandbox denied network access. I did not confirm that the fish 4.9.3 Cargo.lock spells the URL as https://codeberg.org/danielrainer/fluent-ftl-tools, or that the GitHub copy holds commit 5917664c. I did not confirm that the other two git dependencies of fish fetch correctly through the git CLI. A queue build of fish answers all three.
| export CARGO_NET_GIT_FETCH_WITH_CLI=true | ||
| export GIT_CONFIG_COUNT=1 | ||
| export GIT_CONFIG_KEY_0=url.https://github.com/danielrainer/fluent-ftl-tools.insteadOf | ||
| export GIT_CONFIG_VALUE_0=https://codeberg.org/danielrainer/fluent-ftl-tools |
There was a problem hiding this comment.
nit · The title says the redirect is for the time that codeberg.org is down, but the comment gives no removal condition. The redirect stays after codeberg.org returns, and the build then depends on a personal GitHub copy that upstream fish does not reference. Add one sentence that says when to remove these four lines, for example at the next fish version bump after codeberg.org resolves again. I found no other package with this redirect, so the fix is local.
Why
lz4 (#1524) left the merge queue at 07:22Z with
failed_checks. The queue build rebuilt fish, whose Rust compile fetches thefluent-ftl-toolsgit dependency from codeberg.org:codeberg.org is currently NXDOMAIN at the .org registry's own nameservers:
dig codeberg.org NS @v0n0.pir-ns.org +norecursereturns NXDOMAIN, whileexample.organswers normally. Resolvers with a cached record still work and the rest don't. Every queue run that rebuilds fish (lz4, gcc 16 #1545, …) fails until this is fixed or codeberg comes back.Change
packages/fish/build.shpoints git at the author's GitHub copy,github.com/danielrainer/fluent-ftl-tools, which has the pinned commit5917664c8f2e4928ef1e480ff5c13bbe1e226066:GIT_CONFIG_*env setsurl.<github>.insteadOf <codeberg>, so no file is written.CARGO_NET_GIT_FETCH_WITH_CLI=true, because cargo's built-in git client ignores insteadOf.Cargo.lock is unchanged, and cargo still checks out the commit it pins, so the source is the same.
Follow-up
fish still has
needs.internet: crates.io and three git dependencies are fetched at build time. A vendored-crates Source would make it hermetic. Upstream shipsbuild_tools/make_vendor_tarball.shbut doesn't publish a vendor tarball.🤖 Generated with Claude Code
Summary by CodeRabbit