You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Drop gcc-15.2.0-glibc, binutils-2.46-glibc and fastjar; fix the hex0 ladder comment - #1442
Follow-up to #1242, from @msample's review nits (comment). 0 rebuilds: every spec hash on main is unchanged; the dump only loses these three packages.
Removed: three recipes nothing builds
package
importers on main
where it's built now
gcc-15.2.0-glibc
none
gominimal/bootstrap; pkgs pins its gen-13 output in gcc
binutils-2.46-glibc
only gcc-15.2.0-glibc
gominimal/bootstrap; pinned in binutils
fastjar
none
gominimal/bootstrap
All three are in bootstrap's packages/ and generations/gen-13/manifest.json. Removing them leaves no other package without importers.
Fixed: hex0/amd64-ladder.ncl's comment
It still described the 38-package chain, including the go/mrustc/rustc rungs and these seeds. It now names what is still in pkgs (hex0, the stage0-* ladder, glibc-bedrock-2.42: 23 packages) and the one live consumer path. Comments aren't hashed.
msample's open question: should the stage0/hex0 chain stay in pkgs?
Not yet. It still has one consumer: hex0 → stage0-* → glibc-bedrock-2.42 → glibc-bedrock-2.42-sysroot → ghc-9.6.7, ghc, openjdk-21/25/26. Draft #1322 moves those off the sysroot. After that, nothing in pkgs reads the chain, and all 24 packages can go in one PR.
Not changed: glibc-bedrock-2.42/build.sh mentions gcc-15.2.0-glibc in two comments. They're still accurate (bootstrap builds it), and editing a build.sh would rebuild everything downstream of it.
Removed package definitions and build instructions for the glibc-targeted binutils and GCC packages, as well as Fastjar.
Documentation
Updated notes on the amd64 bootstrap switch to clarify which packages it covers and where other toolchain stages are built. The switch remains disabled.
…ladder comment
Follow-up to #1242 (msample's review). Since #1242, nothing in pkgs
imports gcc-15.2.0-glibc or fastjar, and binutils-2.46-glibc's only
importer was gcc-15.2.0-glibc. gominimal/bootstrap builds all three
(generations/gen-13/manifest.json), and pkgs takes their gen-13 outputs
through the gcc and binutils pins, so these copies were dead.
hex0/amd64-ladder.ncl still described the old 38-package chain with the
go/mrustc/rustc rungs. It now names what is left in pkgs (hex0, stage0-*,
glibc-bedrock-2.42: 23 packages) and the one live consumer path
(glibc-bedrock-2.42-sysroot, for ghc and the openjdks).
No spec hash changes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No actionable comments were generated in the recent review.
Walkthrough
The change removes the fastjar, binutils-2.46-glibc, and gcc-15.2.0-glibc package definitions and build files. It also updates comments that describe the amd64 bootstrap ladder and its sealed-artifact consumer.
The binutils and GCC package definitions, build scripts, and stage0 notes are removed. The amd64 ladder comments describe the 23 packages that remain in pkgs, the rungs built in gominimal/bootstrap, and glibc-bedrock-2.42 as the sealed-artifact consumer.
gominimal/pkgs#983: Changes the binutils and GCC source declarations and sealed artifacts that this pull request removes.
Suggested reviewers:norrietaylor
Merge Risk: Minimal · up to 731ba
This change removes unused toolchain package recipes and updates documentation comments. No behavior change or merge-blocking risk was identified.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title accurately identifies the three deleted package recipes and the updated hex0 ladder comment. It is specific and clear enough for the main changes.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between 1419729 and 731ba96.
Files selected for processing: 9
packages/binutils-2.46-glibc/build.ncl
packages/binutils-2.46-glibc/build.sh
packages/binutils-2.46-glibc/stage0.answers
packages/fastjar/build.ncl
packages/fastjar/build.sh
packages/gcc-15.2.0-glibc/build.ncl
packages/gcc-15.2.0-glibc/build.sh
packages/gcc-15.2.0-glibc/stage0.answers
packages/hex0/amd64-ladder.ncl
Files with no reviewable changes: 8
packages/gcc-15.2.0-glibc/stage0.answers
packages/binutils-2.46-glibc/stage0.answers
packages/fastjar/build.ncl
packages/binutils-2.46-glibc/build.ncl
packages/gcc-15.2.0-glibc/build.ncl
packages/fastjar/build.sh
packages/binutils-2.46-glibc/build.sh
packages/gcc-15.2.0-glibc/build.sh
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.
Any commits made after this event will not be merged.
7885
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1242, from @msample's review nits (comment). 0 rebuilds: every spec hash on main is unchanged; the dump only loses these three packages.
Removed: three recipes nothing builds
gcc-15.2.0-glibcgccbinutils-2.46-glibcgcc-15.2.0-glibcbinutilsfastjarAll three are in bootstrap's
packages/andgenerations/gen-13/manifest.json. Removing them leaves no other package without importers.Fixed: hex0/amd64-ladder.ncl's comment
It still described the 38-package chain, including the go/mrustc/rustc rungs and these seeds. It now names what is still in pkgs (hex0, the stage0-* ladder, glibc-bedrock-2.42: 23 packages) and the one live consumer path. Comments aren't hashed.
msample's open question: should the stage0/hex0 chain stay in pkgs?
Not yet. It still has one consumer: hex0 → stage0-* → glibc-bedrock-2.42 → glibc-bedrock-2.42-sysroot → ghc-9.6.7, ghc, openjdk-21/25/26. Draft #1322 moves those off the sysroot. After that, nothing in pkgs reads the chain, and all 24 packages can go in one PR.
Not changed: glibc-bedrock-2.42/build.sh mentions gcc-15.2.0-glibc in two comments. They're still accurate (bootstrap builds it), and editing a build.sh would rebuild everything downstream of it.
🤖 Generated with Claude Code
Summary by CodeRabbit