Repository navigation
amaro: record node's and node-lts's bundled amaro once, in amaro-wasm/versions.ncl - #1389
Open
bryan-minimal wants to merge 1 commit into
Open
bryan-minimal wants to merge 1 commit into
bryan-minimal wants to merge 1 commit into
Conversation
…/versions.ncl node, node-lts and amaro-wasm each carried their own `let amaro = "1.1.11"`, so a bump meant three hand edits and pkgmgr held amaro-wasm every night. versions.ncl now records which amaro each node line bundles plus each version's tag-tarball sha256; node and node-lts import their entry (build.sh still checks deps/amaro), and amaro-wasm builds every distinct version listed. No rebuild: every package's spec hash is unchanged (mip dump, amd64, 661 packages). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
This review includes 4 billable files and costs up to $1.00.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 50 minutes for your next included review. View limit details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node, node-lts and amaro-wasm each carried their own
let amaro = "1.1.11" in. A bump meant three hand edits. pkgmgr's lockstep constraint (pkgmgr-rs#1233) held amaro-wasm, and the nightly posted a Slack warning about it every day ("amaro-wasm 1.1.11 → 1.3.0 ... bump all three recipes together by hand").This PR records the value once, in a new file,
packages/amaro-wasm/versions.ncl:{ bundled = { node = "1.1.11", node-lts = "1.1.11" }, # what each node line ships under deps/amaro tag_sha256 = { "1.1.11" = "f65b4e8a…" }, # nodejs/amaro tag tarball, per version }let amaro = (import "../amaro-wasm/versions.ncl").bundled.node in. build.sh is unchanged and still fails unlessdeps/amaro/package.jsonis that version.bundled, with oneSourceper version (urlfrom the tag,sha256fromtag_sha256). A version listed inbundledwith notag_sha256entry fails evaluation (missing field).upstream_versionis node's entry.No rebuild. I ran
MINIMAL_SCIENCE_MODE=1 mip --no-fetch dump --packages --arch amd64over pkgs main (05187c6) and over this branch. All 661 spec hashes are identical, including node, node-lts and amaro-wasm. Negative control: changing node's entry to 1.3.0 (and adding a placeholder sha) changed all three hashes. amaro-wasm's build_args then becameamaro_versions = "1.3.0 1.1.11", with two amaro Sources. Removing that sha made evaluation fail.What happens on a node bump (companion pkgmgr-rs PR): when the updater bumps node or node-lts, it reads
deps/amaro/package.jsonfrom the new tarball. If the version differs from that line'sbundledentry, it does three things in the same PR:tag_sha256entry;splice deps/amaro/dist/index.jsline.amaro-wasm then rebuilds with node in that PR.
Merge order: merge gominimal/pkgmgr-rs#1246 first, then this PR. pkgmgr-rs#1246 reads both layouts, so this PR merges cleanly after it. If this PR merges first, the pkgmgr running today can't read node's new
let amaroline. It fails closed: amaro-wasm stays held, and the nightly's Slack warning names the unreadable record until pkgmgr-rs#1246 deploys. Nothing gets bumped wrongly either way.Not built locally: the spec hashes are unchanged, so there's nothing new to build.
🤖 Generated with Claude Code