Repository navigation
otel-collector: drop asapauth extension, which panics at init under go 1.27 - #1369
Open
bryan-minimal wants to merge 1 commit into
Open
bryan-minimal wants to merge 1 commit into
bryan-minimal wants to merge 1 commit into
Conversation
…o 1.27 Every otelcol-contrib invocation, --version included, exited 2: panic: crypto: RegisterHash of unknown hash function github.com/SermoDigital/jose/crypto.init.0() crypto/none.go:11 jose registers crypto.Hash(0). Go 1.27 rejects that (golang/go 5a0e0838), so the package has been broken on every arch since the go 1.27.1 bump (#758). Do what upstream did after v0.164.0 (opentelemetry-collector-releases#1742, contrib#51868): take asapauthextension out of the contrib manifest. A guard fails the build once upstream ships the change, so the patch gets dropped. Add --version and components standalone smoke tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 42 minutes for your next included review. View limit details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every
otelcol-contribinvocation,--versionincluded, exits 2 during Go package init:(That trace comes from the cached 0.164.0 artifact, run in an arm64 min session. The 2026-11-06 smoke-test sweep found it first.)
Root cause
extension/asapauthextension. That extension goes throughbitbucket.org/atlassian/go-asap/v2togithub.com/SermoDigital/jose, and jose'scrypto/none.gorunscrypto.RegisterHash(crypto.Hash(0), h)ininit().if h == 0 || h >= maxHash { panic(...) }. In Go 1.26 the check was onlyh >= maxHash.Downgrading Go isn't an option: 1.27.3 is our only non-bootstrap go.
Fix
build.sh: delete the asapauthextension line from the manifest before running ocb, which is what upstream does. The guards fail the build if the line is missing (drop the patch on the bump that already carries upstream's change) and if it is still there after the sed.build.ncl: add standalone smoke testsotelcol-contrib --versionandotelcol-contrib components. Both run every package init. They need no shell, so no test_deps.Verification (arm64, min session)
standalone tests...Fail, both testshad exit code 2.min package build --rebuild --verbose otel-collector: it compiled for real (ocbCompiling21:18, thenCompiled21:24).min check --packages otel-collectorpasses everything,standalone tests...Passincluded. In the session, the installed binary printsotelcol-contrib version 0.164.0, andcomponentslists no asapauth.🤖 Generated with Claude Code